-
Notifications
You must be signed in to change notification settings - Fork 73
OPRUN-4202: Fix issue to sync faced due replace forcing old dependency #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@camilamacedo86: This pull request references OPRUN-4202 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label qe-approved |
@camilamacedo86: This pull request references OPRUN-4202 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@bandrade: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-gcp-olm |
/test e2e-gcp-olm |
/retest-required |
/test e2e-gcp-olm |
2 similar comments
/test e2e-gcp-olm |
/test e2e-gcp-olm |
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
When we tried to sync the build was failing due to:
grpc.SupportPackageIsVersion9
which is generated by
protoc-gen-go-grpc v1.5.1
for code that requires gRPC-Go ≥ v1.64.0.However, the
go.mod
currently includes:replace google.golang.org/grpc => google.golang.org/grpc v1.63.2
This pins the project to an older gRPC version that is incompatible with the generated code.
Fix
Removed the
replace
directive forgoogle.golang.org/grpc
ingo.mod
.The replacement was originally added due to limitations with Go 1.23, but we are now using Go 1.24.4, so it is no longer needed. See: operator-framework/operator-lifecycle-manager#3284
This change aligns the project with the upstream OLM (v0) behavior.