TRT-2130: hcm spike #2778
TRT-2130: hcm spike #2778
Conversation
The release names come from sippy /api/releases which ultimately just draws from a BQ table. They could be anything and Sippy Classic would not really care. Update param.go to just allow anything that looks like a word.
where we care about releases that aren't specified in the DB, add them from the openshift.yaml config file, and then include them according to the new attribute specified there.
openshift-ci-robot
added
the
jira/valid-reference
|
@sosiouxme: This pull request references TRT-2130 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sosiouxme The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@sosiouxme: This pull request references TRT-2130 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| } else if config != nil { | ||
| // Add designated releases from config that aren't represented in the DB | ||
| for name, release := range config.Releases { | ||
| if release.AddRelease { |
There was a problem hiding this comment.
Why does it need to be gated by a boolean? If it's in the config shouldn't we assume it should be shown?
Draft PR for my initial try at adding
hcm-integrationas a release. It would depend on openshift/ci-tools#4624 as well as changes incontinuous-release-jobsto provide the config file and start loading data for the new release. This sort of works, but we have some further issues to work out first.