Skip to content

Add hooks before running kuttl from operator target #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cescgina
Copy link
Contributor

Add a hook to run before calling the kuttl tests in the job variant that runs them from the operator target (wihtout using install_yamls).

Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cescgina. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cescgina added a commit to cescgina/watcher-operator that referenced this pull request Feb 17, 2025
Instead of running at the end of the infra playbook, run it just before
running the tests. This means the watcher operator will be installed
after the openstack-operator is, which will prevent the watcher operator
crashing and having to restart until the openstack-operator is
available.

Depends-On: openstack-k8s-operators/ci-framework#2735
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1a313f9dde5540d4bf979a62d32b880d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 08s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 07s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 09m 59s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 40s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 27s
✔️ cifmw-multinode-kuttl SUCCESS in 2h 15m 49s
✔️ build-push-container-cifmw-client SUCCESS in 22m 22s

cescgina added a commit to cescgina/watcher-operator that referenced this pull request Feb 17, 2025
Instead of running at the end of the infra playbook, run it just after
installing openstack. This means the watcher operator will be installed
after the openstack-operator is present, which will prevent the watcher operator
crashing and having to restart until the openstack-operator is available.

Depends-On: openstack-k8s-operators/ci-framework#2735
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ffd547c7ea2d4d51a022b19251a541dc

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 56s
podified-multinode-edpm-deployment-crc FAILURE in 1h 09m 04s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 14m 42s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 01s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 13s
✔️ cifmw-multinode-kuttl SUCCESS in 2h 15m 09s
✔️ build-push-container-cifmw-client SUCCESS in 18m 17s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4c8ccca3d41342d2b6246fb77d937d09

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 23m 24s
podified-multinode-edpm-deployment-crc FAILURE in 1h 09m 50s
cifmw-crc-podified-edpm-baremetal FAILURE in 46m 47s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 45s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 42s
✔️ cifmw-multinode-kuttl SUCCESS in 2h 31m 48s
✔️ build-push-container-cifmw-client SUCCESS in 22m 27s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c21a659211904a719c6150db23971a6d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 33s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 58s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 22m 03s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 25s
✔️ cifmw-multinode-kuttl SUCCESS in 2h 14m 52s
✔️ build-push-container-cifmw-client SUCCESS in 18m 56s

Add a hook to run before calling the kuttl tests in the job variant that
runs them from the operator target (wihtout using install_yamls). This
change also modifies the run playbook for the kuttl job, to make sure it
runs from the controller.
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/397258b2229f4c5badab3ed1a15cb7d1

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 23s
podified-multinode-edpm-deployment-crc POST_FAILURE in 1h 21m 01s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 15m 22s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 49s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 53s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 36s
cifmw-multinode-kuttl POST_FAILURE in 2h 30m 22s
✔️ build-push-container-cifmw-client SUCCESS in 23m 33s

@cescgina
Copy link
Contributor Author

recheck

@cescgina
Copy link
Contributor Author

cescgina commented Feb 20, 2025

Testing it in nova-operator: openstack-k8s-operators/nova-operator#921 (green run)
Testing in watcher-operator: openstack-k8s-operators/watcher-operator#77 (green run)

@SeanMooney
Copy link
Contributor

/lgtm

i think this is a generally useful change which will make maintaining the jobs simpler.

@SeanMooney
Copy link
Contributor

note this is also needed to unblock nova-operator's check/gate pipeline so we should priories merging this

@SeanMooney
Copy link
Contributor

https://softwarefactory-project.io/zuul/t/rdoproject.org/build/d39c827e69104149a4da49ff88bbab7f

this is a successful end to end run from the watcher-operator using this

Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me but I have limited ci_framework experience so I don't feel the power to approve this.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/70b735e6a59f4d9ba7b757d7562f7cd5

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 14s
podified-multinode-edpm-deployment-crc FAILURE in 1h 15m 16s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 11m 56s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 51s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 34s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 18s
✔️ cifmw-multinode-kuttl SUCCESS in 2h 31m 22s
✔️ build-push-container-cifmw-client SUCCESS in 18m 29s

@cescgina
Copy link
Contributor Author

recheck

Copy link
Contributor

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @cescgina

@pablintino pablintino merged commit 4e847b8 into openstack-k8s-operators:main Feb 24, 2025
7 of 8 checks passed
@cescgina cescgina deleted the add_pre_kuttl_hook branch February 24, 2025 11:04
openshift-merge-bot bot pushed a commit to openstack-k8s-operators/watcher-operator that referenced this pull request Feb 25, 2025
Instead of running at the end of the infra playbook, run it just after
installing openstack. This means the watcher operator will be installed
after the openstack-operator is present, which will prevent the watcher operator
crashing and having to restart until the openstack-operator is available.

Depends-On: openstack-k8s-operators/ci-framework#2735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants