-
Notifications
You must be signed in to change notification settings - Fork 128
Add hooks before running kuttl from operator target #2735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hooks before running kuttl from operator target #2735
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Instead of running at the end of the infra playbook, run it just before running the tests. This means the watcher operator will be installed after the openstack-operator is, which will prevent the watcher operator crashing and having to restart until the openstack-operator is available. Depends-On: openstack-k8s-operators/ci-framework#2735
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1a313f9dde5540d4bf979a62d32b880d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 08s |
7487ff5
to
5cff015
Compare
Instead of running at the end of the infra playbook, run it just after installing openstack. This means the watcher operator will be installed after the openstack-operator is present, which will prevent the watcher operator crashing and having to restart until the openstack-operator is available. Depends-On: openstack-k8s-operators/ci-framework#2735
5cff015
to
ff67d77
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ffd547c7ea2d4d51a022b19251a541dc ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 56s |
ff67d77
to
4571320
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4c8ccca3d41342d2b6246fb77d937d09 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 23m 24s |
4571320
to
a9be4ee
Compare
a9be4ee
to
f878b1c
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c21a659211904a719c6150db23971a6d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 33s |
f878b1c
to
0bae269
Compare
Add a hook to run before calling the kuttl tests in the job variant that runs them from the operator target (wihtout using install_yamls). This change also modifies the run playbook for the kuttl job, to make sure it runs from the controller.
0bae269
to
a909b5d
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/397258b2229f4c5badab3ed1a15cb7d1 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 23s |
recheck |
Testing it in nova-operator: openstack-k8s-operators/nova-operator#921 (green run) |
/lgtm i think this is a generally useful change which will make maintaining the jobs simpler. |
note this is also needed to unblock nova-operator's check/gate pipeline so we should priories merging this |
https://softwarefactory-project.io/zuul/t/rdoproject.org/build/d39c827e69104149a4da49ff88bbab7f this is a successful end to end run from the watcher-operator using this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me but I have limited ci_framework experience so I don't feel the power to approve this.
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/70b735e6a59f4d9ba7b757d7562f7cd5 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 14s |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @cescgina
4e847b8
into
openstack-k8s-operators:main
Instead of running at the end of the infra playbook, run it just after installing openstack. This means the watcher operator will be installed after the openstack-operator is present, which will prevent the watcher operator crashing and having to restart until the openstack-operator is available. Depends-On: openstack-k8s-operators/ci-framework#2735
Add a hook to run before calling the kuttl tests in the job variant that runs them from the operator target (wihtout using install_yamls).