Skip to content

Create hook for adding custom CA certs #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kstrenkova
Copy link
Contributor

This patch enables adding custom CA certs using a hook. The intended usage is in downstream jobs that want to add certificates into the combined-ca-bundle, e.g. internal certificates.

Copy link
Contributor

openshift-ci bot commented May 30, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented May 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kstrenkova kstrenkova force-pushed the add-certs-for-test-operator branch from 35b2c49 to fc5ef0c Compare June 10, 2025 14:29
@kstrenkova kstrenkova marked this pull request as ready for review June 10, 2025 14:29
@kstrenkova kstrenkova requested a review from a team as a code owner June 10, 2025 14:29
@kstrenkova
Copy link
Contributor Author

This patch is being tested here:

I have yet seen a successful run, but I would appreciate some feedback regarding the code. That is why I changed it from draft to an open PR.

@kstrenkova
Copy link
Contributor Author

kstrenkova commented Jun 19, 2025

The testing on the last run was successful, search for python-octavia-tests-tempest here: https://sf.apps.int.gpc.ocp-hub.prod.psi.redhat.com/logs/522/components-integration/522d4f573f5241b59bb4e65872e80fe4/logs/controller-0/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/tempest-tests-tempest-s00-multi-thread-testing/logs/tempest-tests-tempest-tests-runner.log

The job as a whole didn't succeed, but the python-octavia-tests-tempest plugin that was not able to be downloaded before is now downloaded correctly thanks to internal certs.

@kstrenkova kstrenkova requested a review from sdatko June 19, 2025 11:32
@kstrenkova kstrenkova force-pushed the add-certs-for-test-operator branch from d9ca7b2 to ba63cf8 Compare June 19, 2025 12:35
sdatko
sdatko previously approved these changes Jun 19, 2025
Copy link
Contributor

@sdatko sdatko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ❤️ 🎸 :octocat:

This patch enables adding custom CA certs using a hook. The
intended usage is in downstream jobs that want to add certificates
into the combined-ca-bundle, e.g. internal certificates.
Copy link
Contributor

@sdatko sdatko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for misleading you with | required 😅

@kstrenkova kstrenkova requested review from danpawlik and evallesp June 20, 2025 09:12
@sdatko sdatko enabled auto-merge (rebase) June 23, 2025 20:58
@sdatko
Copy link
Contributor

sdatko commented Jun 23, 2025

Seemed it worked fine in testproject, we are good to have it merged IMO 🥇

Copy link
Contributor

@evallesp evallesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdatko sdatko merged commit 23c1cb6 into openstack-k8s-operators:main Jun 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants