-
Notifications
You must be signed in to change notification settings - Fork 127
Create hook for adding custom CA certs #3023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create hook for adding custom CA certs #3023
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
35b2c49
to
fc5ef0c
Compare
This patch is being tested here:
I have yet seen a successful run, but I would appreciate some feedback regarding the code. That is why I changed it from draft to an open PR. |
fc5ef0c
to
d9ca7b2
Compare
The testing on the last run was successful, search for The job as a whole didn't succeed, but the |
d9ca7b2
to
ba63cf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ❤️ 🎸
This patch enables adding custom CA certs using a hook. The intended usage is in downstream jobs that want to add certificates into the combined-ca-bundle, e.g. internal certificates.
ba63cf8
to
240d262
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for misleading you with | required
😅
Seemed it worked fine in testproject, we are good to have it merged IMO 🥇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This patch enables adding custom CA certs using a hook. The intended usage is in downstream jobs that want to add certificates into the combined-ca-bundle, e.g. internal certificates.