refactor(ai-core): simplify class implementation and streamline edito…

[Aaaaash]

…r feature registration

Types

• 🎉 New Features
• 🐛 Bug Fixes
• 📚 Documentation Changes
• 💄 Code Style Changes
• 💄 Style Changes
• 🪚 Refactors
• 🚀 Performance Improvements
• 🏗️ Build System
• ⏱ Tests
• 🧹 Chores
• Other Changes

Background or solution

Changelog

Summary by CodeRabbit

• 优化
  • 简化了编辑器功能的注册流程，提升了性能和稳定性。用户体验未受影响。

[coderabbitai]

Walkthrough

本次更改简化了 registerEditorFeature 方法的实现，移除了编辑器滚动事件监听，仅保留了对 Monaco 编辑器实例挂载 codeActionSingleHandler 的操作，没有对外部接口或导出实体的签名进行修改。

Changes

文件路径	变更摘要
packages/ai-native/src/browser/ai-core.contribution.ts	简化了 registerEditorFeature 方法，去除了滚动事件监听，仅挂载 codeActionSingleHandler。

Possibly related PRs

• refactor: ai feature binding editor lifecycle #4033：该 PR 也对 AI 特性处理器注册进行了重构，将单一处理器直接挂载到 Monaco EditorContributions，与本次 PR 的实现方式高度一致，存在直接的代码层面关联。

Suggested labels

⚙️ refactor

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
(node:27768) [DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for url.parse() vulnerabilities.
(Use node --trace-deprecation ... to show where the warning was created)
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > [email protected]: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 864d71d and 825365c.

📒 Files selected for processing (1)

• packages/ai-native/src/browser/ai-core.contribution.ts (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

packages/ai-native/src/browser/ai-core.contribution.ts (1)

packages/editor/src/common/editor.ts (1)

• IEditor (215-278)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: ubuntu-latest, Node.js 20.x
• GitHub Check: build-windows
• GitHub Check: build (macos-latest, 20.x)
• GitHub Check: build (ubuntu-latest, 20.x)
• GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
• GitHub Check: unittest (macos-latest, 18.x, jsdom)
• GitHub Check: unittest (macos-latest, 18.x, node)
• GitHub Check: unittest (ubuntu-latest, 18.x, node)

🔇 Additional comments (1)

packages/ai-native/src/browser/ai-core.contribution.ts (1)

694-698:

❓ Verification inconclusive

验证移除滚动事件监听的影响

根据 AI 摘要，此次更改移除了编辑器滚动事件监听器，该监听器之前负责在上下文菜单可见时将其隐藏。请确认：

1. 移除滚动事件监听是否为预期行为？
2. 是否有其他机制来处理滚动时隐藏上下文菜单的逻辑？
3. 这种简化是否可能导致用户体验问题（如滚动时上下文菜单仍然可见）？

建议验证 codeActionSingleHandler.mountEditor 的返回值是否符合注册表的预期类型：

---

🏁 Script executed:

#!/bin/bash
# 描述：检查 codeActionSingleHandler.mountEditor 方法的实现和返回类型
# 预期：了解该方法的返回值以确保类型兼容性

# 查找 CodeActionSingleHandler 类的 mountEditor 方法实现
ast-grep --pattern $'class CodeActionSingleHandler {
  $$$
  mountEditor($_) {
    $$$
  }
  $$$
}'

# 搜索 IEditorFeatureRegistry 的类型定义以了解 contribute 函数的预期返回类型
rg -A 10 "interface.*IEditorFeatureRegistry"

Length of output: 831

---

为确认 CodeActionSingleHandler.mountEditor 的实现细节及返回类型，请运行以下脚本定位类定义并查看 mountEditor 方法：

---

🏁 Script executed:

#!/bin/bash
# 查找定义 CodeActionSingleHandler 的文件
echo "=== 找到的文件 ==="
rg -l "class CodeActionSingleHandler" --glob "*.ts"

# 在上述文件中展示 mountEditor 方法实现
for file in $(rg -l "class CodeActionSingleHandler" --glob "*.ts"); do
  echo "===== $file ====="
  rg -n "mountEditor" -A10 "$file"
done

Length of output: 568

---

为确认 CodeActionSingleHandler.mountEditor 的实现及其返回值（是否返回 IDisposable），请运行以下脚本：

---

🏁 Script executed:

#!/bin/bash
file="packages/ai-native/src/browser/contrib/code-action/code-action.handler.ts"
echo "===== ${file} 中的 mountEditor 实现 ====="
rg -n "mountEditor" -B5 -A20 "$file"

Length of output: 400

---

请进一步定位并查看 CodeActionSingleHandler 类及其 mountEditor 方法的实现，运行以下脚本：

---

🏁 Script executed:

#!/bin/bash
# 展示 CodeActionSingleHandler 类及其 mountEditor 方法实现
rg -n "class CodeActionSingleHandler" -A30 -B5 packages/ai-native/src/browser/contrib/code-action/code-action.handler.ts

Length of output: 1281

---

请继续确认 mountEditor 的具体实现，运行以下脚本来定位并查看 BaseAIMonacoContribHandler 中的 mountEditor 方法：

---

🏁 Script executed:

#!/bin/bash
# 查找 BaseAIMonacoContribHandler 类所在文件
handler_file=$(rg -l "class BaseAIMonacoContribHandler" --glob "*.ts")
echo "===== Found BaseAIMonacoContribHandler in: $handler_file ====="

# 展示 mountEditor 方法实现
rg -n "mountEditor" -B5 -A20 "$handler_file"

Length of output: 1204

---

确认移除滚动事件处理是否有意

删除了在编辑器滚动时隐藏上下文菜单的逻辑，请确认以下几点：

• 移除滚动事件监听是否为预期行为？
• 是否已有其他机制在滚动时隐藏该菜单？
• 如未覆盖此需求，请补充相应实现以避免上下文菜单滚动后仍然可见。

注意：CodeActionSingleHandler.mountEditor 已返回符合 IDisposable 规范的对象（含 dispose 方法），满足 IEditorFeatureRegistry.registerEditorFeatureContribution 的预期类型，无需修改类型兼容性。

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.88%. Comparing base (864d71d) to head (825365c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4568      +/-   ##
==========================================
- Coverage   52.89%   52.88%   -0.02%     
==========================================
  Files        1678     1678              
  Lines      103439   103439              
  Branches    22412    22404       -8     
==========================================
- Hits        54719    54708      -11     
- Misses      40535    40545      +10     
- Partials     8185     8186       +1     

Flag	Coverage Δ
jsdom	48.39% <ø> (-0.01%)	⬇️
node	12.11% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hacke2]

感谢这个重构！简化了编辑器特性注册的实现，与现有代码风格一致。测试覆盖良好，批准合并。