Enable setting retention to trait fields #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mouda-corp
requested review from
gerickson,
mrjerryjohns and
robszewczyk
as code owners
mouda-corp
force-pushed
the
wdl_retention
branch
from
2c96495 to
d1f1e79
Compare
mouda-corp
force-pushed
the
wdl_retention
branch
from
d1f1e79 to
9b6cd79
Compare
gerickson
reviewed
Jul 27, 2020
| import "google/protobuf/any.proto"; | ||
| import "google/protobuf/duration.proto"; | ||
| import "google/protobuf/timestamp.proto"; | ||
| import public "storage/datapol/annotations/proto/semantic_annotations.proto"; |
Contributor
There was a problem hiding this comment.
As far as I remember when @mrjerryjohns scrubbed OpenWeave WDLC, these two Protobuf headers are Google-internal-only and are not open source and, consequently, are not appropriate to introduce as external dependencies on the public open source project.
Has that since changed?
Author
There was a problem hiding this comment.
You remember correctly. I talked with Jerry and was told there's a public version available but I am struggling to find it.
And I can't get this CL to compile yet.
@mrjerryjohns FYI.
gerickson
suggested changes
Jul 27, 2020
Contributor
gerickson
left a comment
gerickson
left a comment
There was a problem hiding this comment.
See comment regarding the openness of the two new dependent protobuf headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.