WIP: 🌱 remove no longer required grpc replace (issue: #3284) #3529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
camilamacedo86
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
camilamacedo86
added a commit
that referenced
this pull request
Mar 6, 2025
11 tasks
camilamacedo86
force-pushed
the
grpc-fix-replace
branch
from
d24dbb4 to
b7965e6
Compare
camilamacedo86
force-pushed
the
grpc-fix-replace
branch
from
b7965e6 to
bf220e4
Compare
openshift-bot
pushed a commit
to openshift-bot/operator-framework-olm
that referenced
this pull request
Mar 7, 2025
Motivation: operator-framework/operator-lifecycle-manager#3529 (comment) Upstream-repository: operator-lifecycle-manager Upstream-commit: 5d3239d70edbdfa051c41db517698d355cb5c4a7
openshift-bot
pushed a commit
to openshift-bot/operator-framework-olm
that referenced
this pull request
Mar 13, 2025
Motivation: operator-framework/operator-lifecycle-manager#3529 (comment) Upstream-repository: operator-lifecycle-manager Upstream-commit: 5d3239d70edbdfa051c41db517698d355cb5c4a7
openshift-bot
pushed a commit
to openshift-bot/operator-framework-olm
that referenced
this pull request
Mar 14, 2025
Motivation: operator-framework/operator-lifecycle-manager#3529 (comment) Upstream-repository: operator-lifecycle-manager Upstream-commit: 5d3239d70edbdfa051c41db517698d355cb5c4a7
openshift-merge-robot
added
the
needs-rebase
camilamacedo86
force-pushed
the
grpc-fix-replace
branch
from
bf220e4 to
af5502b
Compare
openshift-merge-robot
removed
the
needs-rebase
camilamacedo86
force-pushed
the
grpc-fix-replace
branch
from
af5502b to
87be2e2
Compare
camilamacedo86
force-pushed
the
grpc-fix-replace
branch
from
87be2e2 to
fdc4da1
Compare
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
joelanford
reviewed
Jun 10, 2025
| @@ -163,7 +163,7 @@ func grpcConnection(address string) (*grpc.ClientConn, error) { | |||
| })) | |||
| } | |||
|
|
|||
| return grpc.Dial(address, dialOptions...) | |||
| return grpc.NewClient(address, dialOptions...) | |||
There was a problem hiding this comment.
I'm not sure we should make this change. I see that grpc.Dial is deprecated, but reading the GoDoc of grpc.DialContext (which is called by grpc.Dial), it sounds like there are subtle differences that may matter to us:
// One subtle difference between NewClient and Dial and DialContext is that the
// former uses "dns" as the default name resolver, while the latter use
// "passthrough" for backward compatibility. This distinction should not matter
// to most users, but could matter to legacy users that specify a custom dialer
// and expect it to receive the target string directly.
We do use a custom dialer if there is a proxyURL.
grokspawn
pushed a commit
to grokspawn/operator-framework-olm
that referenced
this pull request
Jun 11, 2025
Motivation: operator-framework/operator-lifecycle-manager#3529 (comment) Upstream-repository: operator-lifecycle-manager Upstream-commit: 5d3239d70edbdfa051c41db517698d355cb5c4a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3284