Skip to content

[Native Image] [Windows] Required environment variable names use case-sensitive compare on Windows #11819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stooke
Copy link
Contributor

@stooke stooke commented Jul 29, 2025

This is a simple fix for #11818 (Required environment variable names use case-sensitive compare on Windows).
The call to mapKey() is inlined into the call to isKeyRequiredCondition().
Currently this particular call to mapKey() has no effect.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 29, 2025
@stooke stooke changed the title [Native Image] [Windows] Required environment variable names use case-sensitive compare on Windows #11818 [Native Image] [Windows] Required environment variable names use case-sensitive compare on Windows Jul 29, 2025
Copy link
Collaborator

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The existing code is clearly wrong whereas this version ensures the lookup uses upper case for the key on Windows. I am not an official reviewer so perhaps areal one could take a look at this.

@adinn adinn requested review from chumer and alexander-schubert and removed request for alexander-schubert July 30, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants