Skip to content

feat: add callgraph and build cmd detection for Jenkins #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

behnazh-w
Copy link
Member

@behnazh-w behnazh-w commented Feb 6, 2025

Summary:

This PR introduces the construction of callgraphs for bash scripts inlined within Jenkinsfile configurations. Additionally, it creates BuildToolCommand objects, which will be utilized in the build-related checks. With this update, Jenkins is no longer categorized as an unparsed CI service, although parsing support remains partial.

Tests:

  • An integration test has been added for the pkg:maven/org.apache.dubbo/[email protected] artifact, which uses Jenkins for builds.
  • The expected result in tests/integration/cases/jenkinsci_plotplugin has been updated to reflect the absence of a build service command.

TODO:

Similar to GitHub Actions, we aim to support recursive calls to bash scripts within Jenkinsfile. The implementation should be straightforward, but it is recommended to first refactor the bashparser to decouple it from GitHub Actions, making it more general: #978

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 6, 2025
@behnazh-w behnazh-w force-pushed the behnazh/improve-build-cmd-detection branch 2 times, most recently from dbe2525 to 1bd3563 Compare February 6, 2025 06:51
@behnazh-w behnazh-w marked this pull request as ready for review February 6, 2025 08:30
@behnazh-w behnazh-w requested a review from tromai as a code owner February 6, 2025 08:30
@behnazh-w behnazh-w requested a review from nicallen February 6, 2025 08:31
Copy link
Member

@tromai tromai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finished the first round of review. I left some questions about the PR. Thank you.

@behnazh-w behnazh-w force-pushed the behnazh/improve-build-cmd-detection branch from 1bd3563 to 21c36d0 Compare March 18, 2025 04:42
@behnazh-w behnazh-w merged commit 23c7fdb into staging Mar 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants