FIX 2 : handling commands, type switch removal #1064
+59
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: soulaimanGhailan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
|
andytael
reviewed
Jun 12, 2025
| @@ -1,6 +1,11 @@ | |||
| package org.example.oracle.cqrs.command.commands; | |||
|
|
|||
| import lombok.*; | |||
There was a problem hiding this comment.
Don't use *, use the specific imports.
andytael
reviewed
Jun 12, 2025
| @@ -1,6 +1,10 @@ | |||
| package org.example.oracle.cqrs.command.commands; | |||
|
|
|||
| import lombok.*; | |||
There was a problem hiding this comment.
Don't use *, use the specific imports.
andytael
reviewed
Jun 12, 2025
| @@ -13,6 +13,7 @@ | |||
| import org.example.oracle.cqrs.common.Dtos.DebitAccountDTO; | |||
| import org.example.oracle.cqrs.common.Dtos.UpdateAccountStatusDTO; | |||
| import org.example.oracle.cqrs.common.events.BaseEvent; | |||
| import org.springframework.http.HttpHeaders; | |||
| import org.springframework.http.HttpStatus; | |||
| import org.springframework.http.ResponseEntity; | |||
| import org.springframework.web.bind.annotation.*; | |||
There was a problem hiding this comment.
Don't use *, use the specific imports.
andytael
reviewed
Jun 12, 2025
| @@ -37,27 +38,27 @@ public ResponseEntity createAccount(@Valid @RequestBody CreateAccountDTO request | |||
| String accountId = UUID.randomUUID().toString(); | |||
| commandsProducer.enqueue(new CreateAccountCommand(UUID.randomUUID().toString(), request.getInitialBalance(), request.getCurrency(), accountId)); | |||
|
|
|||
| return ResponseEntity.status(HttpStatus.ACCEPTED).header("Location", "/api/queries/status/" + accountId).build(); | |||
| return ResponseEntity.status(HttpStatus.ACCEPTED).header(HttpHeaders.LOCATION, "/api/queries/status/" + accountId).build(); | |||
There was a problem hiding this comment.
I don't think this should be hardcoded /api/queries/status/ maybe use something like this, just an example:
URI location = ServletUriComponentsBuilder
.fromCurrentRequest()
.path("/{accountId}")
.buildAndExpand(newCustomer.getCustomerId())
.toUri();
return ResponseEntity.created(location).build();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.