Skip to content

chore: link to the config to flatten custom claims in Hydra #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

chore: link to the config to flatten custom claims in Hydra #2250

wants to merge 5 commits into from

Conversation

deepakprabhakara
Copy link
Contributor

@deepakprabhakara deepakprabhakara commented Jul 24, 2025 •
edited
Loading

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@deepakprabhakara
Added a link to the config to flatten custom claims in Hydra, it isn'…
d193711 
…t very obvious that this config exists unless you stumble upon it from somewhere else (like search)
zepatrik
zepatrik requested changes Jul 24, 2025
View reviewed changes
vinckr
vinckr requested changes Jul 24, 2025
View reviewed changes
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit, otherwise gtg

@deepakprabhakara @vinckr
code review changes
798deb1 
Co-authored-by: Vincent <[email protected]>
@deepakprabhakara deepakprabhakara requested a review from vinckr July 24, 2025 15:41
@deepakprabhakara
Copy link
Contributor Author

@vinckr Realized there is another config so created a link to that which is the right thing to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

@zepatrik zepatrik Awaiting requested review from zepatrik

@vinckr vinckr Awaiting requested review from vinckr vinckr is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@deepakprabhakara deepakprabhakara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepakprabhakara @zepatrik @vinckr