Skip to content

Merge feature/events into foxy-devel #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 31, 2020
Merged

Merge feature/events into foxy-devel #24

merged 13 commits into from
Aug 31, 2020

Conversation

* Create LivelinessLostEvent

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

* Fix linking issue

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

* Rename disposeEventHandler to removeEventHandler

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

* Use synchronized methods in EventHandlerImpl

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

* Use createEventHandler instead of registerEventHanlder

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

* nit

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

* Clarify ownership of the event handle

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno added the enhancement New feature or request label Aug 28, 2020
@ivanpauno ivanpauno requested a review from jacobperron August 28, 2020 21:35
@ivanpauno ivanpauno self-assigned this Aug 28, 2020
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Copy link

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give that I've already reviewed the incremental PRs, I didn't look too closely at this one.

@ivanpauno ivanpauno merged commit af574cb into foxy-devel Aug 31, 2020
@ivanpauno ivanpauno deleted the feature/events branch August 31, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants