Fix API Error when error body is empty #68
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, Thanks for contributing! Also, please squash these 4 commits. |
deathiop
reviewed
Apr 14, 2023
| @@ -397,24 +397,36 @@ func (c *Client) CallAPIWithContext(ctx context.Context, method, path string, re | |||
| // UnmarshalResponse checks the response and unmarshals it into the response | |||
| // type if needed Helper function, called from CallAPI | |||
| func (c *Client) UnmarshalResponse(response *http.Response, resType interface{}) error { | |||
| // Read all the response body | |||
| defer response.Body.Close() | |||
rbeuque74
requested changes
Apr 18, 2023
| @@ -397,24 +397,36 @@ func (c *Client) CallAPIWithContext(ctx context.Context, method, path string, re | |||
| // UnmarshalResponse checks the response and unmarshals it into the response | |||
| // type if needed Helper function, called from CallAPI | |||
| func (c *Client) UnmarshalResponse(response *http.Response, resType interface{}) error { | |||
There was a problem hiding this comment.
Suggested change
| func (c *Client) UnmarshalResponse(response *http.Response, resType interface{}) error { | |
| func (c *Client) UnmarshalResponse(response *http.Response, resType interface{}) error { | |
| // Read all the response body | |
| defer response.Body.Close() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an API call is returning a bad status code (!=200) and no body, the client return the body read error EOF instead of the error code. It's more difficult to debug and understand what happened.
A call to POST /cloud/project/*/instance with a bad or empty image id will return EOF.
With this patch, it return the 404 error saying an object is not found.
It's not perfect as the API should return the exact error, but more useful than EOF.