-
Notifications
You must be signed in to change notification settings - Fork 203
minicbor-lease
adapter for encoding straight into a lease
#2164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hawkw
wants to merge
7
commits into
eliza/snitch-again
Choose a base branch
from
eliza/minicbor-lease
base: eliza/snitch-again
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd vote to keep it separate! Review to come (either this afternoon or Monday) |
mkeeter
reviewed
Jul 18, 2025
mkeeter
reviewed
Jul 18, 2025
mkeeter
reviewed
Jul 18, 2025
mkeeter
reviewed
Jul 18, 2025
@mkeeter opened an upstream issue to make the minicbor API less annoying: twittner/minicbor#36 |
Co-authored-by: Matt Keeter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a suggestion from @mkeeter, this branch adds an adapter that implements
minicbor::encode::write::Write
for a cursor into a writable lease. This lets us avoid double-buffering in theread_ereports
path, where we would previously encode each ereport into the receive buffer, and then copy the contents of that into the lease if there is space for it. The new approach avoids the memcpy, and also doesn't encode the ereport in the case where there isn't space left for it.I implemented the lease-writer adapter thing in a separate
minicbor-lease
crate, as I was hoping it would be useful elsewhere...but I'm not actually sure if it will be, now that I think of it: the IPC for delivering an ereport to packrat leases the data from the caller, so callers will just encode into a normal buffer they own. Ah well.