-
Notifications
You must be signed in to change notification settings - Fork 58
Add omdb nexus fetch-omdb
#9172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Testing on a4x2; this is the "not really useful" bit but confirming that all the plumbing is correct:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of adding a step to the end-to-end tests that uses omdb nexus fetch-omdb
and runs that omdb to do something basic?
The existing end-to-end tests only exercise the public API, AFAICT, but it was easy to add a check to the deploy job directly: ba33090 |
This PR adds a copy of the
omdb
binary into the Nexus zone. This allows anomdb
running in the switch zone to fetch a potentially-differentomdb
binary from a running Nexus instance. In a steady state this is useless, but during an update, the switch zone is updated much earlier than the database schema or Nexus, leading to difficulty observing the progress of the update. As a pretty cheap workaround, shipping omdb with Nexus means we can always grab a version that matches the currently-active Nexus (which will always match the current database schema).Closes #9075, which has more details about the kinds of errors we can see mid-update.