-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add helm charts #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 71.37% 71.28% -0.10%
==========================================
Files 200 198 -2
Lines 18191 18210 +19
==========================================
- Hits 12984 12981 -3
- Misses 4492 4507 +15
- Partials 715 722 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a2d0da6
to
04615f7
Compare
d137574
to
fbdd65d
Compare
875ea40
to
56f5c0c
Compare
@@ -0,0 +1,44 @@ | |||
version: "3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need additional docker-compose files for helm charts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's just sample of docker-compose files for local deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe @dkharms meant, that we already have docker-compose
files in quickstart/
directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's what I meant. We already have all necessary docker-compose files for quickstart in quickstart/
directory.
{{- range $i := until (.Values.replicaCount | int) }} | ||
- {{ $.Release.Name }}-{{ $i }}.{{ $.Release.Name }}.{{ $.Release.Namespace }}.svc.cluster.local.:9004 | ||
{{- end }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it's not full list of configuration options - https://ozontech.github.io/seq-db-docs/seq-db/configuration
How user will be able to override this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now you can override config by .Values.seqproxy.config
storage: | ||
data_dir: /data | ||
{{- if .Values.storage.frac_size }} | ||
frac_size: {{ .Values.storage.frac_size }} | ||
{{- end }} | ||
{{- if .Values.storage.total_size }} | ||
total_size: {{ .Values.storage.total_size }} | ||
{{- end }} | ||
mapping: | ||
enable_updates: {{ .Values.mapping.enable_updates }} | ||
{{- if .Values.mapping.auto }} | ||
path: auto | ||
{{- else }} | ||
path: /mappings/mappings.yaml | ||
{{- end }} | ||
update_period: {{ .Values.mapping.update_period }} | ||
slow_logs: | ||
bulk_threshold: 0ms | ||
fetch_threshold: 3s | ||
search_threshold: 3s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the same question (as https://github.com/ozontech/seq-db/pull/130/files#r2398224119) here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now you can override config by .Values.config
### Install | ||
|
||
```shell | ||
helm upgrade --install seq-db . -f values.minikube.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While reading this some questions came up:
- How I can specify replicas count for seqdb (as store) for seqdb (as proxy)?
- Where configuration files are located?
- Why there are two dirs for
seq-ui
andseq-proxy
but there is no one forseq-db
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How I can specify replicas count for seqdb (as store) for seqdb (as proxy)?
You can set number of replicas by values (values.minikube.yaml):
replicaCount: 2
seqproxy:
enabled: true
replicaCount: 1
or using args:
helm upgrade --install seq-db . -f values.minikube.yaml --set replicaCount=1,seqproxy.replicaCount=1
Where configuration files are located?
Configmaps generates using values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe delete this file?
Description
I helm-charts for deploy in kubernetes
for test:
If you have used LLM/AI assistance please provide model name and full prompt: