Skip to content

Conversation

DmitryRomanov
Copy link

@DmitryRomanov DmitryRomanov commented Sep 11, 2025

Description

I helm-charts for deploy in kubernetes

for test:

cd deployment/k8s/helm-chart
helm upgrade --install -f values.minikube.yaml seq-db .  --dry-run --debug > output.yaml

  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.28%. Comparing base (abd6bfb) to head (b62c612).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   71.37%   71.28%   -0.10%     
==========================================
  Files         200      198       -2     
  Lines       18191    18210      +19     
==========================================
- Hits        12984    12981       -3     
- Misses       4492     4507      +15     
- Partials      715      722       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DmitryRomanov DmitryRomanov marked this pull request as ready for review September 30, 2025 10:58
@@ -0,0 +1,44 @@
version: "3.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need additional docker-compose files for helm charts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just sample of docker-compose files for local deployment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @dkharms meant, that we already have docker-compose files in quickstart/ directory

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's what I meant. We already have all necessary docker-compose files for quickstart in quickstart/ directory.

{{- range $i := until (.Values.replicaCount | int) }}
- {{ $.Release.Name }}-{{ $i }}.{{ $.Release.Name }}.{{ $.Release.Namespace }}.svc.cluster.local.:9004
{{- end }}
{{- end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's not full list of configuration options - https://ozontech.github.io/seq-db-docs/seq-db/configuration

How user will be able to override this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you can override config by .Values.seqproxy.config

Comment on lines 12 to 31
storage:
data_dir: /data
{{- if .Values.storage.frac_size }}
frac_size: {{ .Values.storage.frac_size }}
{{- end }}
{{- if .Values.storage.total_size }}
total_size: {{ .Values.storage.total_size }}
{{- end }}
mapping:
enable_updates: {{ .Values.mapping.enable_updates }}
{{- if .Values.mapping.auto }}
path: auto
{{- else }}
path: /mappings/mappings.yaml
{{- end }}
update_period: {{ .Values.mapping.update_period }}
slow_logs:
bulk_threshold: 0ms
fetch_threshold: 3s
search_threshold: 3s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you can override config by .Values.config

### Install

```shell
helm upgrade --install seq-db . -f values.minikube.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While reading this some questions came up:

  • How I can specify replicas count for seqdb (as store) for seqdb (as proxy)?
  • Where configuration files are located?
  • Why there are two dirs for seq-ui and seq-proxy but there is no one for seq-db?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How I can specify replicas count for seqdb (as store) for seqdb (as proxy)?

You can set number of replicas by values (values.minikube.yaml):

replicaCount: 2
seqproxy:
  enabled: true
  replicaCount: 1

or using args:

helm upgrade --install seq-db . -f values.minikube.yaml --set replicaCount=1,seqproxy.replicaCount=1

Where configuration files are located?

Configmaps generates using values

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe delete this file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants