feat(series): arithmetic mul #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Aug 19, 2025
tests/series/arithmetic/test_mul.py
Outdated
Comment on lines
46
to
49
| check(assert_type(b * left, pd.Series), pd.Series) # type: ignore[assert-type] | ||
| check(assert_type(i * left, pd.Series), pd.Series) # type: ignore[assert-type] | ||
| check(assert_type(f * left, pd.Series), pd.Series) # type: ignore[assert-type] | ||
| check(assert_type(c * left, pd.Series), pd.Series) # type: ignore[assert-type] |
There was a problem hiding this comment.
Somehow mypy thinks that Series has the protocol SupportsIndex. So here i a fix. Add this line to the beginning of class Series:
# Define __index__ because mypy thinks Series follows protocol `SupportsIndex`
__index__: ClassVar[None]Then you can get rid of the ignores.
There was a problem hiding this comment.
Looks like this is known: python/mypy#19341
Dr-Irv
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by #1274 and a follow-up for #1312.
assert_type()to assert the type of any return value