-
Notifications
You must be signed in to change notification settings - Fork 58
Adds the bundled feature. #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, I'd love to see this included :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Too bad we can't test that in CI, I wonder if anyone else can test this on a live system...
The bundled feature is ment to make the process of building and managing the tpm2-tss depedency of the tss-esapi-sys crate much easier by downloading the source code and compiling it automatically. This feature was originally developed in \parallaxsecond#523 and then updated in \parallaxsecond#531. Co-authored-by: William Brown <[email protected]> Co-authored-by: Thomas Epperson <[email protected]> Signed-off-by: Jesper Brynolf <[email protected]>
09c29f6
to
8e7f02c
Compare
I mean running the bundled feature in an linux CI would not be that difficult. And even running a CI that just builds the thing on windows might not be that troublesome either. |
The bundled feature is ment to make the process of building and managing the tpm2-tss depedency of the tss-esapi-sys crate much easier by downloading the source code and compiling it automatically.
This feature was originally developed in #523 and then updated in #531.