Skip to content

Conversation

Superhepper
Copy link
Collaborator

The bundled feature is ment to make the process of building and managing the tpm2-tss depedency of the tss-esapi-sys crate much easier by downloading the source code and compiling it automatically.

This feature was originally developed in #523 and then updated in #531.

Copy link
Contributor

@Firstyear Firstyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, I'd love to see this included :)

wiktor-k
wiktor-k previously approved these changes Aug 29, 2025
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Too bad we can't test that in CI, I wonder if anyone else can test this on a live system...

The bundled feature is ment to make the process of building
and managing the tpm2-tss depedency of the tss-esapi-sys
crate much easier by downloading the source code and
compiling it automatically.

This feature was originally developed in \parallaxsecond#523 and then updated
in \parallaxsecond#531.

Co-authored-by: William Brown <[email protected]>
Co-authored-by: Thomas Epperson <[email protected]>
Signed-off-by: Jesper Brynolf <[email protected]>
@Superhepper
Copy link
Collaborator Author

Looks good in general. Too bad we can't test that in CI, I wonder if anyone else can test this on a live system...

I mean running the bundled feature in an linux CI would not be that difficult. And even running a CI that just builds the thing on windows might not be that troublesome either.
But getting it to run the tests bow that would be a whole different beast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants