Repeat ping request periodically #416
Open
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _ = interval.tick() => { | ||
| for peer in &self.peers { | ||
| tracing::trace!(target: LOG_TARGET, ?peer, "sending ping"); | ||
| if let Err(error) = self.service.open_substream(*peer) { |
There was a problem hiding this comment.
The libp2p ping protocol spec states that the repeated pings should go on the same substream: https://github.com/libp2p/specs/blob/master/ping/ping.md
Because of this, the issue is actually more difficult due to the need to not keep the connection alive by this ping substream.
I don't think we should break the spec even if it works with the current libp2p implementation. @lexnv what do you think?
There was a problem hiding this comment.
Indeed, I would comply with the libp2p spec as much as possible. The main issue would be that we cannot distinguish ping susbtreams for the keep alive connection tracker 🤔
Are we entirely convinced we need to implement this for ping?
- we'll need to adjust the substream API to expose that the substream is ping (accounting towards the keepalive)
- how do we treat failures here? If we cannot open a substream should we terminate the connection? If so, we need to propagate again to the higher levels the signal to terminate the connection
- offhand, from ping we'll need to propagate towards the transport manager, and from the transport manager we'll need to propagate to individual connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #415