CHORE: Support build docker image locally with make docker-build command #1138
Conversation
Signed-off-by: LinPr <[email protected]>
LinPr
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
| @@ -71,7 +72,10 @@ init: ## Install linters | |||
| cd tools && go generate -x -tags=tools | |||
|
|
|||
| build: ## Build exporter binary using plain go build. | |||
| go build -ldflags="$(GO_BUILD_LDFLAGS)" -o $(PMM_RELEASE_PATH)/mongodb_exporter | |||
| CGO_ENABLED=0 go build -ldflags="$(GO_BUILD_LDFLAGS)" -o $(PMM_RELEASE_PATH)/mongodb_exporter | |||
There was a problem hiding this comment.
why do we need this here though?
There was a problem hiding this comment.
just make sure it is static builded, make it more portable, sometimes I want to copy the builded binary to another machine, I can run it without considering the enviroment of glibc or musl
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1138 +/- ##
==========================================
- Coverage 70.88% 65.10% -5.79%
==========================================
Files 28 29 +1
Lines 3569 3092 -477
==========================================
- Hits 2530 2013 -517
- Misses 904 939 +35
- Partials 135 140 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CHORE: Support build docker image locally with make docker-build command