Skip to content

Fix: Skip the non-exist namespaces when there are multiple mongo instance metrics to scrape #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LinPr
Copy link

@LinPr LinPr commented Aug 13, 2025

Refer to this issue: #1144

Changes:

  1. skip the non-exist namespaces when there are multiple mongo instance metrics to scrape
  2. by the way the listAllCollections(ctx, client, collections, nil, true) need to pass collections as the third parameter to reduce the databases and collections to list, wihich can improve the performance

@LinPr LinPr requested a review from a team as a code owner August 13, 2025 12:46
@LinPr LinPr requested review from BupycHuk and JiriCtvrtka and removed request for a team August 13, 2025 12:46
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.09%. Comparing base (dc46ed5) to head (23c3c41).
⚠️ Report is 123 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
- Coverage   70.88%   65.09%   -5.80%     
==========================================
  Files          28       29       +1     
  Lines        3569     3091     -478     
==========================================
- Hits         2530     2012     -518     
- Misses        904      939      +35     
- Partials      135      140       +5     
Flag Coverage Δ
agent 65.09% <100.00%> (-5.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant