feat(fetcher): add configurable timeout for httpx fetcher #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opal-docs canceled.
|
omer9564
requested changes
Apr 6, 2025
packages/opal-common/opal_common/fetcher/providers/http_fetch_provider.py
Outdated
Show resolved
Hide resolved
packages/opal-common/opal_common/fetcher/providers/http_fetch_provider.py
Outdated
Show resolved
Hide resolved
…nd update description
omer9564
reviewed
Apr 20, 2025
There was a problem hiding this comment.
pre-commit is failing, besides of that looks good
Will ask @danyi1212 about the failing tests, I think that an irrelevant issue
fixed |
omer9564
reviewed
Apr 22, 2025
There was a problem hiding this comment.
The tests are failing with this error:
https://github.com/permitio/opal/actions/runs/14570395803/job/40866484393?pr=782#step:7:405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Cloes #756
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers