-
Notifications
You must be signed in to change notification settings - Fork 2
Tooltip changes #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip changes #78
Conversation
ClaudiaGivan
commented
Jun 25, 2025
- add the ticket id and link to it for the control renderer
- hide tooltip after click
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances tooltip interactions by linking ticket IDs to their URLs and hiding the tooltip on click. It also adds the ticket link for the Control chart and updates constructor parameters to pass the ticket base URL.
- Added
on('click', hideTooltip())
handlers to links and mouseleave events - Introduced
workTicketsURL
into the ControlRenderer constructor and tooltip - Included ticket ID links in the ControlRenderer tooltip
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/graphs/work-item-age/WorkItemAgeRenderer.js | Added debug log in hideTooltip and click handler |
src/graphs/scatterplot/ScatterplotRenderer.js | Added click handler and debug log on mouseleave |
src/graphs/moving-range/MovingRangeRenderer.js | Added click handlers; second link .text parameter |
src/graphs/control-chart/ControlRenderer.js | Expanded constructor, added debug log and ticket link |
Comments suppressed due to low confidence (4)
src/graphs/work-item-age/WorkItemAgeRenderer.js:209
- Remove this console.log debugging statement or replace it with a proper logger before merging.
console.log("hide tooltip")
src/graphs/scatterplot/ScatterplotRenderer.js:618
- Consider removing or disabling this debug log in production code to avoid console noise.
console.log("setup mouse leave to hide tooltip")
src/graphs/control-chart/ControlRenderer.js:9
- Adding
workTicketsURL
to the constructor is a breaking change. Ensure all instantiation sites are updated or provide a default value to avoid runtime errors.
constructor(data, avgMovingRangeFunc, chartName, workTicketsURL) {
src/graphs/control-chart/ControlRenderer.js:54
- Remove this console.log or replace it with a structured logger to avoid cluttering the console.
console.log('populateTooltip', event);
22b3b52
to
25a99fb
Compare
- add the ticket id and link to it for the control renderer - hide tooltip after click
25a99fb
to
4415b88
Compare
@@ -50,12 +51,19 @@ export class ControlRenderer extends ScatterplotRenderer { | |||
} | |||
|
|||
populateTooltip(event) { | |||
console.log('populateTooltip', event); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Console.log?