Skip to content

Tooltip changes #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Tooltip changes #78

merged 1 commit into from
Jun 25, 2025

Conversation

ClaudiaGivan
Copy link
Collaborator

  • add the ticket id and link to it for the control renderer
  • hide tooltip after click

@ClaudiaGivan ClaudiaGivan requested review from butsyk and Copilot June 25, 2025 10:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances tooltip interactions by linking ticket IDs to their URLs and hiding the tooltip on click. It also adds the ticket link for the Control chart and updates constructor parameters to pass the ticket base URL.

  • Added on('click', hideTooltip()) handlers to links and mouseleave events
  • Introduced workTicketsURL into the ControlRenderer constructor and tooltip
  • Included ticket ID links in the ControlRenderer tooltip

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/graphs/work-item-age/WorkItemAgeRenderer.js Added debug log in hideTooltip and click handler
src/graphs/scatterplot/ScatterplotRenderer.js Added click handler and debug log on mouseleave
src/graphs/moving-range/MovingRangeRenderer.js Added click handlers; second link .text parameter
src/graphs/control-chart/ControlRenderer.js Expanded constructor, added debug log and ticket link
Comments suppressed due to low confidence (4)

src/graphs/work-item-age/WorkItemAgeRenderer.js:209

  • Remove this console.log debugging statement or replace it with a proper logger before merging.
    console.log("hide tooltip")

src/graphs/scatterplot/ScatterplotRenderer.js:618

  • Consider removing or disabling this debug log in production code to avoid console noise.
        console.log("setup mouse leave to hide tooltip")

src/graphs/control-chart/ControlRenderer.js:9

  • Adding workTicketsURL to the constructor is a breaking change. Ensure all instantiation sites are updated or provide a default value to avoid runtime errors.
  constructor(data, avgMovingRangeFunc, chartName, workTicketsURL) {

src/graphs/control-chart/ControlRenderer.js:54

  • Remove this console.log or replace it with a structured logger to avoid cluttering the console.
    console.log('populateTooltip', event);

@ClaudiaGivan ClaudiaGivan force-pushed the control-renderer-tooltip branch from 22b3b52 to 25a99fb Compare June 25, 2025 10:48
- add the ticket id and link to it for the control renderer
- hide tooltip after click
@ClaudiaGivan ClaudiaGivan force-pushed the control-renderer-tooltip branch from 25a99fb to 4415b88 Compare June 25, 2025 10:51
@@ -50,12 +51,19 @@ export class ControlRenderer extends ScatterplotRenderer {
}

populateTooltip(event) {
console.log('populateTooltip', event);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console.log?

@ClaudiaGivan ClaudiaGivan merged commit 78a7ec9 into main Jun 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants