Skip to content

Create PBCRenderer.js component for Individuals and MR charts together #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

ClaudiaGivan
Copy link
Collaborator

No description provided.

@ClaudiaGivan ClaudiaGivan requested review from butsyk and Copilot July 10, 2025 10:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new PBCRenderer component to render paired individuals (control) and moving range charts, along with related styling and defaults updates.

  • Added PBCRenderer to orchestrate control and moving range charts in one component
  • Switched default timeScale from linear to logarithmic in both renderers
  • Updated tooltip styles (background and metric colors) and adjusted base renderer dimensions

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/index.js Imported and exported the new PBCRenderer
src/graphs/tooltipStyles.module.css Changed tooltip background and metric color values
src/graphs/pbc/PBCRenderer.js Added new PBCRenderer class to render PBC and MR charts together
src/graphs/moving-range/MovingRangeRenderer.js Updated default timeScale from linear to logarithmic
src/graphs/control-chart/ControlRenderer.js Updated default timeScale from linear to logarithmic
src/graphs/Renderer.js Adjusted height and focusHeight constants for layout
Comments suppressed due to low confidence (4)

src/graphs/pbc/PBCRenderer.js:11

  • [nitpick] Inconsistent casing: default chartName is lowercase 'pbc' while chartType is uppercase 'PBC'. Consider aligning casing conventions for clarity.
    this.chartType = 'PBC';

src/graphs/moving-range/MovingRangeRenderer.js:6

  • Default timeScale was changed from 'linear' to 'logarithmic'. Ensure existing tests cover both scales and verify that downstream behavior remains correct.
  timeScale = 'logarithmic';

src/graphs/control-chart/ControlRenderer.js:6

  • Default timeScale was updated from 'linear' to 'logarithmic'. Add or update tests to validate chart rendering with the new default scale.
  timeScale = 'logarithmic';

src/graphs/tooltipStyles.module.css:47

  • Mismatch between the color value 'yellow' and comment 'orange'. Update the comment to match the actual color or revert to the original hex code for clarity.
  color: yellow; /* orange */

@ClaudiaGivan ClaudiaGivan merged commit 0e91f7c into main Jul 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant