Add qos_network_id option to ports create/update #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

tduncan8 wants to merge 3 commits into php-opencloud:master from tduncan8:add_qos_function

tduncan8 commented Mar 11, 2025

add qos_network_id to ports create/update to allow this field to be readable/writeable https://docs.openstack.org/api-ref/network/v2/index.html

tduncan8 added 2 commits

March 11, 2025 10:39


          Add qos_policy_id to ports

bbd1e08


          minor update

7c1b7f6

Member

k0ka commented Mar 16, 2025

Hello,

Thank you for the PR. Could you create some tests for this feature? At least add a unit test with some real response from the server to make sure it is working properly. Like this:
https://github.com/php-opencloud/openstack/blob/master/tests/unit/Networking/v2/Models/PortTest.php#L50
https://github.com/php-opencloud/openstack/blob/master/tests/unit/Networking/v2/Fixtures/port_get.resp


          Merge branch 'master' into add_qos_function

f66361f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet