Deprecate producing output in a user output handler #19067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielEScherzer
requested review from
bukka,
alexdowad and
youkidearitai
as code owners
DanielEScherzer
force-pushed
the
output-from-handler
branch
from
6f4022d to
bce9555
Compare
Girgias
reviewed
Jul 9, 2025
Girgias
approved these changes
Jul 9, 2025
TimWolla
reviewed
Jul 10, 2025
Comment on lines
+981
to
+982
| zend_string *handler_name = handler->name; | ||
| zend_string_addref(handler_name); |
There was a problem hiding this comment.
This would be a little cleaner as zend_string *handler_name = zend_string_copy(handler->name);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/deprecations_php_8_4