Zend: fix undefined symbol 'execute_ex' on Windows ARM64 Issue#19064 #19068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ext/gd: fix emmintrin.h not found on Windows ARM64
hyh19962008
changed the title
|
Nice catch ! we do not have windows arm64 CI. @cmb69 does it look good to you ? |
|
This looks generally good to me, but zend_vm_execute.h needs to be regenerated since zend_vm_execute.h has been changed (see zend_vm_gen.php). I'm not quite sure what to do about gd_interpolation.c; upstream doesn't have these lines, and I think they are superfluous; but it doesn't hurt to apply this patch for now. |
nielsdos
approved these changes
Jul 8, 2025
| @@ -62,7 +62,7 @@ | |||
| #include "gdhelpers.h" | |||
| #include "gd_intern.h" | |||
|
|
|||
| #ifdef _MSC_VER | |||
| #if defined(_MSC_VER) && (defined(_M_IX86) || defined(_M_X64)) | |||
There was a problem hiding this comment.
We have a matching pragma optimize down below.
Probably, the include should just be dropped?
There was a problem hiding this comment.
The upstream libgd has removed these lines, it might be safe to remove them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ext/gd: fix emmintrin.h not found on Windows ARM64. emmintrin.h is x86 specific.