Invoke destructors during bailout #19080
Open
+53
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danog
changed the title
| @@ -28,3 +28,4 @@ int(2) | |||
| Deprecated: Passing E_USER_ERROR to trigger_error() is deprecated since 8.4, throw an exception or call exit with a string message instead in %s on line %d | |||
|
|
|||
| Fatal error: Fatal error in fiber in %sfatal-error-with-multiple-fibers.php on line %d | |||
| executed | |||
There was a problem hiding this comment.
please keep the trailing newline
| </{closure:%s:%d}> | ||
| <!-- switching from fiber %s to %s --> | ||
| <destroyed '%s'> | ||
| <!-- destroy: %s --> |
There was a problem hiding this comment.
please keep a trailing newline
| --FILE-- | ||
| <?php | ||
|
|
||
| final class StatCounter { |
There was a problem hiding this comment.
This seems more complicated than you need
<?php
class StatCounter {
public function __construct(private array $stats) {}
public function __destruct() {
echo "Sending stats: ".json_encode($this->stats)."\n";
}
}
$stats = new StatCounter(['test' => 1, 'test2' => 1]);
set_time_limit(1);
while (1);should do the same thing
| Invoke destructors after bailout | ||
| --SKIPIF-- | ||
| <?php | ||
| if (getenv("SKIP_SLOW_TESTS")) die("skip slow test"); |
There was a problem hiding this comment.
the test is limited to one second, I don't think that counts as slow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18418.