-
Notifications
You must be signed in to change notification settings - Fork 33
Enhanced RSS Feeds with RFC-Specific Features #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enhanced RSS Feeds with RFC-Specific Features #41
Conversation
I think this would be good to have, but we don't "own" the wiki software. It is dokuwiki, and we really shouldn't be patching the core system. (We make an exception for the doodle plugin, which is no longer maintained). |
i wonder if this could be a separated plugin perhaps somehow? i can't actually find one for docuwiki that does it. i can't see a way of hooking into the feed without directly changing dokuwiki source (open to ideas and happy to work with people to make it happen) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks pretty good, but I've some comments, and suggested changes.
It would also be lovely to see a fully generated feed.
|
||
## Summary | ||
|
||
This PR adds three new RSS feed modes to the PHP wiki with enhanced RFC tracking capabilities, providing the PHP community with comprehensive feeds for staying informed about RFC developments, voting activities, and general wiki changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this DESCRIPTION.md
file shouldn't be in the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct - this was me planning how to describe it for the pr - will remove.
<item> | ||
<title>RFC: Add new array functions [Status Changed: Discussion → Voting]</title> | ||
<description> | ||
RFC status changed from Discussion to Voting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSS feed item's content should be in HTML. Right now, my RSS feed reader would just cobble everything together in one line (like HTML and XML would). Changing the content of each item to properly marked up HTML (with escaping, if needed), is probably wise to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh interesting - i thought it was XML still - will change.
Enhanced RSS Feeds with RFC-Specific Features
Summary
This PR adds three new RSS feed modes to the PHP wiki with enhanced RFC tracking capabilities, providing the PHP community with comprehensive feeds for staying informed about RFC developments, voting activities, and general wiki changes.
Background
Currently, the PHP wiki provides a single RSS feed that combines all wiki changes. This makes it difficult for community members to:
This enhancement was discussed on a live podcast and addresses the community's need for better RFC change tracking.
Features Added
Three Distinct Feed Modes
?mode=recent
) - Enhanced existing feed with RFC metadata?mode=rfc-only
) - New feed focused exclusively on RFC activities?mode=non-rfc
) - New feed for all non-RFC wiki contentEnhanced RFC Processing
rfc-status-change
,rfc-voting-start
,rfc-new
Feed URLs
RFC Enhancement Controls
Example Enhanced Feed Content
RFC Status Change
Technical Implementation
Files Modified
dokuwiki/inc/Feed/FeedCreatorOptions.php
- Added RFC enhancement options and new modesdokuwiki/inc/Feed/FeedCreator.php
- Added RFC filtering and processing logicdokuwiki/feed.php
- Updated documentation for new parametersFiles Added
dokuwiki/inc/Feed/RFCFeedItemProcessor.php
- RFC-specific processing and metadata extractionBackward Compatibility
Benefits
For RFC Authors
For PHP Community
For Tools and Aggregators
Testing
The implementation includes comprehensive RFC detection and processing:
rfc:*
pages)Impact
This enhancement provides the PHP community with the RSS feed functionality discussed in recent podcasts, enabling better tracking of RFC activities and more informed participation in PHP's development process.