Skip to content

Conversation

jacklul
Copy link
Contributor

@jacklul jacklul commented Jul 18, 2025

What does this PR aim to accomplish?:

In some cases kill -RTMIN can send incorrect signal value to the FTL causing it to terminate instead of performing lists reload.
#2573

How does this PR accomplish the above?:

Undocumented sigrtmin action is added which returns the value of SIGRTMIN FTL expects
That value can be used by the pihole script to send the correct signal

PR on the script side: pi-hole/pi-hole#6358


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Jack'lul <[email protected]>
@jacklul jacklul requested a review from a team as a code owner July 18, 2025 09:05
@DL6ER DL6ER changed the title Add sigrtmin action Add sigrtmin option Jul 18, 2025
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

On Ubuntu 24.04:

$ pihole-FTL sigrtmin
34

On Alpine Linux 3.21:

$ pihole-FTL sigrtmin
35

@DL6ER DL6ER enabled auto-merge July 18, 2025 09:23
@DL6ER DL6ER merged commit 4acf415 into pi-hole:development Jul 18, 2025
12 checks passed
@yubiuser
Copy link
Member

Should we amend this doc?

https://docs.pi-hole.net/ftldns/signals/

@DL6ER
Copy link
Member

DL6ER commented Jul 19, 2025

Well, the docs are already circumventing this by using exact numbers:

image

But this is, of course, only correct for the pre-built binaries and those built under musl compilers (e.g. in the devcontainer). Everyone building this locally on Debian, Ubuntu, Fedora, ... will have glibc so the numbers in the docs are wrong. I tend to agree we should amend this. Feel free to do it if you have a spare minute, I'm not sure when I can sit down and do it myself.

Probably something like:

The numbers in parentheses assume RTMIN=35, you can verify this on your particular system using the pihole-FTL ...

@yubiuser
Copy link
Member

pi-hole/docs#1270

@yubiuser yubiuser linked an issue Jul 22, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

running "pihole reloadlists" is killing "pihole-FTL.service"

3 participants