-
-
Notifications
You must be signed in to change notification settings - Fork 190
OAuth Manager and OAuth2/OpenID connect Plugin #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
markus-96
wants to merge
11
commits into
pikvm:oauth-prototype
Choose a base branch
from
markus-96:oauth
base: oauth-prototype
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still having three errors with mypy: kvmd\plugins\auth\oauth2.py:142: error: Function is missing a return type annotation [no-untyped-def] kvmd\apps\kvmd\oauth.py:102: error: Function is missing a return type annotation [no-untyped-def] kvmd\apps\kvmd\oauth.py:117: error: Function is missing a return type annotation [no-untyped-def]
Jfyi I don't forget about it, just very busy with other tasks. |
If you were notified by my merges of upstream, sry for that. Had to do the merges because otherwise I was not able to get it running on actual hardware. Take your time, I only was in a hurry when writing the code and getting it on the pi. |
I'm lazy working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to define OAuth Providers as authentication backend.
/etc/kvmd/auth.yaml
has to look like the following:It will define two Providers. Both are identified by the key for their config dict, so we have two:
keycloak
andgithub
The first one, GitHub, is accessable withhttps://<PiKVM>/api/auth/oauth/login/github
, the second one, Keycloak, withhttps://<PiKVM>/api/auth/oauth/login/keycloak
. The callback urls arehttps://<PiKVM>/api/auth/oauth/callback/<provider-key>
.The oauth2 plugin implements the authorization code flow.