Skip to content

tidb: mark tidb_mpp_store_fail_ttl as deprecated #21410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions system-variables.md
Original file line number Diff line number Diff line change
Expand Up @@ -4079,12 +4079,16 @@ As shown in this diagram, when [`tidb_enable_paging`](#tidb_enable_paging-new-in

### tidb_mpp_store_fail_ttl

> **Warning:**
>
> Starting from v9.0.0, this variable is deprecated and its value is fixed to `0s`. This means TiDB no longer waits before sending queries to newly started TiFlash nodes, as the delay is no longer necessary to prevent query failures.

- Scope: SESSION | GLOBAL
- Persists to cluster: Yes
- Applies to hint [SET_VAR](/optimizer-hints.md#set_varvar_namevar_value): No
- Type: Duration
- Default value: `60s`
- The newly started TiFlash node does not provide services. To prevent queries from failing, TiDB limits the tidb-server sending queries to the newly started TiFlash node. This variable indicates the time range in which the newly started TiFlash node is not sent requests.
- Default value: Before v9.0.0, the default value is `60s`. Starting from v9.0.0, the default value is `0s`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

To improve readability and avoid repetition, you can make this description more concise.1

Style Guide References

Suggested change
- Default value: Before v9.0.0, the default value is `60s`. Starting from v9.0.0, the default value is `0s`.
- Default value: `60s` before v9.0.0; `0s` from v9.0.0.

Footnotes

  1. Avoid unnecessary words and repetition. (link)

- The newly started TiFlash node does not provide services. To prevent queries from failing, TiDB limits the tidb-server from sending queries to the newly started TiFlash node. This variable indicates the time range in which the newly started TiFlash node is not sent requests.

### tidb_multi_statement_mode <span class="version-mark">New in v4.0.11</span>

Expand Down