variables.json: add a variable for TiDB Cloud console URL (#21450) #21453
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
area/develop
|
@qiancai This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've reviewed this pull request, which aims to improve the maintainability and consistency of documentation by externalizing the TiDB Cloud console URL into a dedicated configuration variable. This change allows for easier updates to the URL across documentation if it ever changes, reducing the need for multiple manual modifications.
Highlights
- Configuration Management: A new variable,
console-url, has been introduced invariables.jsonto centralize the base URL for the TiDB Cloud console. - Documentation Update: The
develop/dev-guide-sample-application-python-peewee.mdfile has been updated to utilize the newly definedconsole-urlvariable, replacing a previously hardcoded URL.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new variable console-url to centralize the TiDB Cloud console URL, which is a great step for maintainability. There's a critical issue in variables.json where merge conflict markers are present, which will break JSON parsing.
variables.json
Outdated
| <<<<<<< HEAD | ||
| "dedicated": "TiDB Cloud Dedicated" | ||
| ======= | ||
| "dedicated": "TiDB Cloud Dedicated", | ||
| "console-url": "tidbcloud.com" | ||
| >>>>>>> 9d745773c4 (variables.json: add a variable for TiDB Cloud console URL (#21450)) |
There was a problem hiding this comment.
This file contains merge conflict markers (<<<<<<<, =======, >>>>>>>). This will result in an invalid JSON file and will likely break the documentation build process. Please resolve the conflict.
"dedicated": "TiDB Cloud Dedicated",
"console-url": "tidbcloud.com"
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiancai
removed
the
do-not-merge/hold
This is an automated cherry-pick of #21450
What is changed, added or deleted? (Required)
This PRs adds a variable "console-url" for the TiDB Cloud console URL.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?