-
Notifications
You must be signed in to change notification settings - Fork 704
Do not merge until v8.5.4: distribute-table: support to scatter the region distribution of the given table and engine (#20345) #21883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
Conversation
Co-authored-by: Aolin <[email protected]>
…ssential are still at 7.5.x
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances TiDB's data distribution capabilities by introducing a suite of new SQL statements. These statements empower users to actively manage and monitor the scattering of table regions across different storage engines like TiKV and TiFlash. The primary goal is to ensure a more balanced data distribution, thereby optimizing performance and preventing hotspots, with explicit commands for initiating, canceling, and observing these critical operations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for several new SQL statements related to table data distribution: DISTRIBUTE TABLE
, CANCEL DISTRIBUTION JOB
, SHOW DISTRIBUTION JOBS
, and SHOW TABLE DISTRIBUTION
. The changes look good overall. I've added several comments with suggestions to improve clarity, accuracy, and consistency, following the repository's style guide. My feedback includes correcting an inaccurate description, fixing a broken SQL example, and suggesting adding descriptions for output columns to make the documentation more complete for users.
|
||
# SHOW DISTRIBUTION JOBS <span class="version-mark">New in v9.0.0</span> | ||
|
||
The `SHOW DISTRIBUTION JOBS` statement shows all current Region distribution jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description is slightly inaccurate. The statement shows all created jobs, including finished
and cancelled
ones, not just "current" jobs as the example output shows. Consider rephrasing for accuracy.1
The `SHOW DISTRIBUTION JOBS` statement shows all current Region distribution jobs. | |
The `SHOW DISTRIBUTION JOBS` statement shows all Region distribution jobs that have been created. |
Style Guide References
Footnotes
-
Repository Style Guide, line 16: Technical accuracy and terminology consistency ↩
|
||
## Examples | ||
|
||
Show all current Region distribution jobs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word "current" is inaccurate here, as the command shows historical jobs as well. It's better to remove it.1
Show all current Region distribution jobs: | |
Show all Region distribution jobs: |
Style Guide References
Footnotes
-
Repository Style Guide, line 16: Technical accuracy and terminology consistency ↩
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@bufferflies: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #20345
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?