Add --sigterm
flag
#65
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--sigterm
flag (matching coverage.py'ssigterm
flag) to still write the coverage output if aSIGTERM
signal is sent.Helpful for using slipcover in e.g. docker containers.
Tested with a simple
while True: ...
script and then akill -SIGTERM
. I'm not too familiar with what sort of cleanup may be necessary for more complex cases, so I'd welcome any suggestions on how to truly gracefully exit.Also, this currently ignores
--fail-under
, since it exits immediately instead. I'm happy to update it to e.g. raise an exception that is caught by a context manager surrounding therunpy
/exec
calls, so that the normal flow in__main__
afterwards is maintained. I chose not to for now, since theatexit
isn't currently doing that either.Thanks for creating/maintaining this project!