-
Notifications
You must be signed in to change notification settings - Fork 6
chore: change rmdir to rm #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Yep, that was necessary when the repo was private for the CI to be able to pull it, but I think that should not be necessary anymore. Also, |
Yes. i'm getting the same as nrwl/nx#7739 |
The dependency has been fixed with #37. There was some additional CI changes which needed to happen alongside it, so I just reproduced the PR. |
If you want to update this PR to get rid of the dep change, I can merge this to fix the rmdir warning. Otherwise, I can reproduce that myself too, if you prefer. 🙂 |
d0e2c0f
to
22fbb3e
Compare
Done 😊. Thank you |
I'll see about rebasing this tomorrow after #39 lands. I missed that before. Once that's in there the lint should pass properly. 🙂 |
Hey there!
When running pnpm build on a fresh clone, the build fails because Cargo cannot fetch the ext-php-rs dependency. This happens because the dependency is referenced with an SSH URL, which requires authentication.
Extra: removed deprecated rmdir from test/util.mjs