Skip to content

fix: Use HTTPS for ext-php-rs git dependency to fix local build #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jlucaso1
Copy link

@jlucaso1 jlucaso1 commented Jun 10, 2025

Hey there!
When running pnpm build on a fresh clone, the build fails because Cargo cannot fetch the ext-php-rs dependency. This happens because the dependency is referenced with an SSH URL, which requires authentication.

error: failed to get `ext-php-rs` as a dependency ...
Caused by:
  Unable to update ssh://[email protected]/platformatic/ext-php-rs.git
Caused by:
  failed to authenticate when downloading repository

Extra: removed deprecated rmdir from test/util.mjs

jlucaso1 added 2 commits June 9, 2025 21:10
Switches the `ext-php-rs` git dependency from SSH to HTTPS. The SSH URL requires authentication and causes build failures for contributors without configured SSH keys. The public HTTPS URL resolves this.
@jlucaso1 jlucaso1 changed the title fix: Replace deprecated rmdir with rm in MockRoot clean method fix: Use HTTPS for ext-php-rs git dependency to fix local build Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant