Skip to content

feat: restore header case-insensitivity #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

Qard
Copy link
Member

@Qard Qard commented Jun 17, 2025

This restores header case-insensitivity so users don't need to think about that when passing in headers.

@Qard Qard self-assigned this Jun 17, 2025
@Qard Qard added the enhancement New feature or request label Jun 17, 2025
@Qard Qard force-pushed the restore-header-case-insensitivity branch from 4ceae78 to 9821660 Compare June 17, 2025 11:59
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests for this?

@Qard
Copy link
Member Author

Qard commented Jun 17, 2025

Already has tests, that's what's failing right now. 🙈

@Qard Qard force-pushed the restore-header-case-insensitivity branch from 9821660 to 3625809 Compare June 17, 2025 16:22
@Qard Qard force-pushed the restore-header-case-insensitivity branch from 3625809 to 19e31d1 Compare June 17, 2025 16:24
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Qard Qard merged commit 66ab114 into main Jun 18, 2025
11 checks passed
@Qard Qard deleted the restore-header-case-insensitivity branch June 18, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants