-
Notifications
You must be signed in to change notification settings - Fork 39
Adding da Canvas samples #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added disclaimer from AI-EDU-Samples repo
Added disclaimer from AI-EDU-Samples repo
Aligning naming between Teacher and Student agents
Feedback from Mast
Feedback from Mast
Thanks @jmenegazzo I’ll review on Monday 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I've reviewed the da-CanvasStudent
sample and left some comments. Let's address these before we move onto da-CanvasTeacher
.
Simplifying "Agent samples for Education" section
Features and version history now part of Summary
Admin permissions update
Code block
BizChat only
removing extra space
Removing extra space
Tables adjusted
Removing <br>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added .vscode folder and made changes to yml file (missed in the first review)
Removed dependency on M365 Copilot license and added reference doc for more details
Additional guidance around custom app upload settings
Teams app > app manifest Co-authored-by: Garry Trinder <[email protected]>
Removed `en-us` locale code Co-authored-by: Garry Trinder <[email protected]>
Updated capabilities with M365 Copilot license requirements
Updated MAC steps, removed TAC
updated schema version URL Co-authored-by: Garry Trinder <[email protected]>
gallery image order Co-authored-by: Garry Trinder <[email protected]>
gallery image order pnp#2
Updated Minimal path to awesome (configuration)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments addressed, waiting for meeting to validate configuration steps, OAuth registration, conversation starters, and yml file references.
Updated and broke down Minimal path to awesome and Optional configuration sections
Replaced teamsapp.yml with m365agents.yml reference
Removed capabilities/conversation starters
Updated examples in data access
README and ai-plugin.json files updated. All points addressed, moving to Canvas Teacher now |
Remove comments in help
Sync with changes we've made for Canvas Student
Removing final references to Canvas Student
Additional metadata added
Updated order for images and references
Removed EN-US references
Removed capabilities and conversation starters
Updated manifest version
Updates made to Canvas Teacher too :) Please let me know if I missed anything and I'll fix it on Friday |
Adding 2 Education agents to the PnP Repo. Updated docs with