Skip to content

Adding da Canvas samples #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 61 commits into
base: main
Choose a base branch
from

Conversation

jmenegazzo
Copy link

Adding 2 Education agents to the PnP Repo. Updated docs with

  • Updated README with EDU disclaimer, M365 agents Toolkit, removing references to future versions
  • Updated assets with higher resolution screenshots for the gallery
  • Created metadata files for Canvas Teacher and Canvas Student (assets/sample.json)

@garrytrinder garrytrinder self-assigned this Jun 14, 2025
@garrytrinder
Copy link
Member

Thanks @jmenegazzo I’ll review on Monday 👍

Copy link
Member

@garrytrinder garrytrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've reviewed the da-CanvasStudent sample and left some comments. Let's address these before we move onto da-CanvasTeacher.

@garrytrinder garrytrinder marked this pull request as draft June 16, 2025 14:17
Simplifying "Agent samples for Education" section
Features and version history now part of Summary
Admin permissions update
Code block
BizChat only
removing extra space
Removing extra space
Tables adjusted
Removing <br>
Copy link
Author

@jmenegazzo jmenegazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added .vscode folder and made changes to yml file (missed in the first review)

@jmenegazzo jmenegazzo marked this pull request as ready for review June 17, 2025 21:55
jmenegazzo and others added 11 commits June 18, 2025 11:02
Removed dependency on M365 Copilot license and added reference doc for more details
Additional guidance around custom app upload settings
Added additional guidance for options steps pnp#2 and pnp#4
Teams app > app manifest

Co-authored-by: Garry Trinder <[email protected]>
Removed `en-us` locale code

Co-authored-by: Garry Trinder <[email protected]>
Updated capabilities with M365 Copilot license requirements
Updated MAC steps, removed TAC
updated schema version URL

Co-authored-by: Garry Trinder <[email protected]>
gallery image order

Co-authored-by: Garry Trinder <[email protected]>
gallery image order pnp#2
Updated Minimal path to awesome (configuration)
Copy link
Author

@jmenegazzo jmenegazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed, waiting for meeting to validate configuration steps, OAuth registration, conversation starters, and yml file references.

Updated and broke down Minimal path to awesome and Optional configuration sections
Replaced teamsapp.yml with m365agents.yml reference
Removed capabilities/conversation starters
Updated examples in data access
@jmenegazzo jmenegazzo requested a review from garrytrinder June 19, 2025 19:36
@jmenegazzo
Copy link
Author

README and ai-plugin.json files updated. All points addressed, moving to Canvas Teacher now

Remove comments in help
Sync with changes we've made for Canvas Student
Removing final references to Canvas Student
Updated order for images and references
Removed EN-US references
Removed capabilities and conversation starters
Updated manifest version
@jmenegazzo
Copy link
Author

Updates made to Canvas Teacher too :) Please let me know if I missed anything and I'll fix it on Friday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants