forked from flashbots/op-rbuilder
-
Notifications
You must be signed in to change notification settings - Fork 0
PoC builder mode selecting TXs from an auction running on pod #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
poszu
wants to merge
9
commits into
main
Choose a base branch
from
pod-builder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new Pod payload builder mode in the op-rbuilder crate that selects transactions based on auction bids from a Pod network. Key changes include:
- Adding a new BuilderMode::Pod in the launcher and builders modules
- Implementing the PodBuilder, its configuration (PodArgs and Config), and PodClient to interact with auction bids
- Integrating the Pod mode into the CLI and dependency updates in Cargo.toml
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
crates/op-rbuilder/src/launcher.rs | Added Pod mode support in the launch function |
crates/op-rbuilder/src/builders/pod/pod_client.rs | Introduced PodClient for fetching and sorting auction bids |
crates/op-rbuilder/src/builders/pod/payload.rs | Implemented the PodPayloadBuilder and integration with async logic |
crates/op-rbuilder/src/builders/pod/mod.rs | Added PodBuilder entry point and service builder creation |
crates/op-rbuilder/src/builders/pod/config.rs | Defined configuration mapping for the Pod builder |
crates/op-rbuilder/src/args/op.rs | Introduced PodArgs for Pod mode configuration |
crates/op-rbuilder/src/args/mod.rs | Added flag to select Pod mode |
crates/op-rbuilder/Cargo.toml | Added dependencies for pod-sdk, pod-auction, and itertools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a new
Pod
payload builder mode in theop-rbuilder
crate. The changes include adding configurations, arguments, and implementation for thePod
builder, which integrates with an auction system to select transactions based on bids. Below is a summary of the most important changes grouped by theme.Builder Mode Enhancements:
Pod
builder mode to theBuilderMode
enum, enabling block building based on transaction bids from an auction system. (crates/op-rbuilder/src/builders/mod.rs
, crates/op-rbuilder/src/builders/mod.rsR39-R42)PodBuilder
struct with a block-building strategy that uses auction data to select transactions. (crates/op-rbuilder/src/builders/pod/mod.rs
, crates/op-rbuilder/src/builders/pod/mod.rsR1-R37)Configuration and Argument Updates:
PodArgs
struct to define arguments for enabling thePod
mode, specifying RPC URL, and contract address. (crates/op-rbuilder/src/args/op.rs
, crates/op-rbuilder/src/args/op.rsR155-R174)Config
struct for thePodBuilder
, mappingPodArgs
to configuration values. (crates/op-rbuilder/src/builders/pod/config.rs
, crates/op-rbuilder/src/builders/pod/config.rsR1-R20)Integration with Auction System:
PodClient
struct to interact with the auction system, fetch bids, and sort transactions by bid amount. (crates/op-rbuilder/src/builders/pod/pod_client.rs
, crates/op-rbuilder/src/builders/pod/pod_client.rsR1-R95)Launcher Updates:
launch
function to include support for launching thePod
builder mode. (crates/op-rbuilder/src/launcher.rs
, crates/op-rbuilder/src/launcher.rsR61-R65)Dependency Additions:
pod-sdk
,pod-auction
, anditertools
, to support thePod
builder functionality. (crates/op-rbuilder/Cargo.toml
, crates/op-rbuilder/Cargo.tomlR136-R139)