-
Notifications
You must be signed in to change notification settings - Fork 60
Security solution images from widgets #2862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Overall
Let's use the "img" tags for the images and control the width and border line. in your case the images are dark so it looks fine without the border lines but we can reduce the sizes so they don't look too big.
Not at 100% all the time. some of the images can be resized to 80% to look better in context
- Trigger security scans based on code changes and deployment patterns | ||
- Integrate security testing into CI/CD pipelines with intelligent fail/pass decisions | ||
- Generate security test cases based on application architecture and attack patterns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Periods at the end of every list item
:::tip Transform metrics into actionable insights | ||
**Port transforms security metrics from vanity numbers into actionable insights, helping CISOs, security teams, and developers align on what truly matters.** | ||
::: | ||
|
||
:::tip Unify security strategy and execution | ||
**From prioritizing vulnerabilities to visualizing progress, Port unifies security strategy and execution in one powerful platform.** | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't advise showing two different admonitions like this in a row
Can we find another way to communicate this ?
description: | ||
globs: | ||
alwaysApply: false | ||
globs: **/*.md | ||
alwaysApply: true | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you modified the rules 😃
please revert this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting
- Regulatory scope (SOC 2, PCI, HIPAA, GDPR), | ||
- Data sensitivity (PII, payment data, internal-only), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Regulatory scope (SOC 2, PCI, HIPAA, GDPR). | |
- Data sensitivity (PII, payment data, internal-only). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! I kept staring at this sentences for a very long time until I noticed my punctuation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Including images from port app for security solutions
Updated docs pages