Skip to content

First attempt at genericizing data source (improved!) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

chendaniely
Copy link
Contributor

@chendaniely chendaniely commented Jun 3, 2025

(Moved TODO items into #21 and #22).

Squash merged into #20 via c6a24a7


Original PR comment:

Updates, changes, fixing conflicts from #5

TODO:

  • create more examples with different database engines (e.g., snowflake, databricks, etc)
  • for snowflake use the user:pass string, but also show example for using snowflake.connector.connect
  • Check readme for new api changes that take dataframe or sqlalchemy connection
  • Check readme for new api changes of returning a querychat object not dict

From the #5 TODO:

  • Use narwhals instead of Pandas directly
  • Have options to limit the number of rows retrieved, or perhaps retrieve in chunks or a cursor, so big databases won't blow up your Shiny app

@chendaniely chendaniely changed the base branch from main to dev June 4, 2025 01:02
@chendaniely
Copy link
Contributor Author

closing. manually squash merged into #20 via c6a24a7 to preserve Joe as the author of the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants