Skip to content

Conversation

parthverma1
Copy link
Contributor

Added support for an SSL key log file to facilitate debugging encrypted network traffic. Updated dependency postman-request to include the relevant SSL key logging feature.

Added support for an SSL key log file to facilitate debugging encrypted network traffic. Updated dependency `postman-request` to include the relevant SSL key logging feature.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds SSL key logging functionality to enable debugging of encrypted network traffic by allowing users to specify a file path for logging SSL session keys.

  • Updated postman-request dependency to use a feature branch with SSL key logging support
  • Added debug option configuration that gets passed through the runner chain
  • Implemented SSL key log file path extraction and assignment to request options

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updated postman-request dependency to feature branch
lib/runner/index.js Added debug options to runner configuration
lib/requester/requester-pool.js Extracted SSL key log file path from debug options
lib/requester/core.js Assigned SSL key log file to request options
README.md Added documentation for debug.sslKeyLogFile option

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.89%. Comparing base (45114b3) to head (61929dc).

❗ There is a different number of reports uploaded between BASE (45114b3) and HEAD (61929dc). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (45114b3) HEAD (61929dc)
unit 4 1
integration 3 0
legacy 3 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1532       +/-   ##
============================================
- Coverage    75.29%   41.89%   -33.40%     
============================================
  Files           49       49               
  Lines         3789     3790        +1     
  Branches      1085     1085               
============================================
- Hits          2853     1588     -1265     
- Misses         712     2078     +1366     
+ Partials       224      124      -100     
Flag Coverage Δ
integration ?
legacy ?
unit 41.89% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

appurva21
appurva21 previously approved these changes Oct 16, 2025
@appurva21 appurva21 merged commit 234ae5d into develop Oct 16, 2025
6 of 12 checks passed
@appurva21 appurva21 deleted the feature/ssl-keylog branch October 16, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants