-
Notifications
You must be signed in to change notification settings - Fork 121
feat: add support for SSL key logging #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added support for an SSL key log file to facilitate debugging encrypted network traffic. Updated dependency `postman-request` to include the relevant SSL key logging feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds SSL key logging functionality to enable debugging of encrypted network traffic by allowing users to specify a file path for logging SSL session keys.
- Updated
postman-request
dependency to use a feature branch with SSL key logging support - Added
debug
option configuration that gets passed through the runner chain - Implemented SSL key log file path extraction and assignment to request options
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
package.json | Updated postman-request dependency to feature branch |
lib/runner/index.js | Added debug options to runner configuration |
lib/requester/requester-pool.js | Extracted SSL key log file path from debug options |
lib/requester/core.js | Assigned SSL key log file to request options |
README.md | Added documentation for debug.sslKeyLogFile option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #1532 +/- ##
============================================
- Coverage 75.29% 41.89% -33.40%
============================================
Files 49 49
Lines 3789 3790 +1
Branches 1085 1085
============================================
- Hits 2853 1588 -1265
- Misses 712 2078 +1366
+ Partials 224 124 -100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Added support for an SSL key log file to facilitate debugging encrypted network traffic. Updated dependency
postman-request
to include the relevant SSL key logging feature.