Skip to content

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Oct 1, 2025

references

changes

  • crates/pixi_task/src/task_hash.rs
    • include task args in hashed created by TaskHash.task_args_hash

@bollwyvl bollwyvl changed the title add task args to cache filename hash feat: add task args to cache filename hash Oct 1, 2025
Copy link
Collaborator

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucascolley lucascolley changed the title feat: add task args to cache filename hash feat(tasks): add task args to cache filename hash Oct 6, 2025
@lucascolley lucascolley added enhancement New features area:tasks Related to pixi tasks labels Oct 6, 2025
@lucascolley lucascolley self-requested a review October 6, 2025 21:50
)


def test_caching_multiple_tasks_with_depends_on_args(pixi: Path, tmp_pixi_workspace: Path) -> None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bollwyvl, new test looks good to me! Just one question

) -> list[Path]:
"""Run a task, return the cache paths."""
verify_cli_command(
[*map(str, [pixi.resolve(), "run", "--manifest-path", manifest_path, *args])],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary to call .resolve() here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucascolley lucascolley merged commit 957b554 into prefix-dev:main Oct 7, 2025
38 checks passed
@lucascolley
Copy link
Collaborator

thanks again!

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Oct 7, 2025

thanks!

@bollwyvl bollwyvl deleted the gh-4675-task-arg-cache-hash branch October 7, 2025 13:03
Hofer-Julian pushed a commit to Hofer-Julian/pixi that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tasks Related to pixi tasks enhancement New features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants