-
Notifications
You must be signed in to change notification settings - Fork 356
feat(tasks): add task args to cache filename hash #4676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tasks): add task args to cache filename hash #4676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bollwyvl ! Could we add a test in https://github.com/prefix-dev/pixi/blob/main/tests/integration_python/test_run_cli.py ?
) | ||
|
||
|
||
def test_caching_multiple_tasks_with_depends_on_args(pixi: Path, tmp_pixi_workspace: Path) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a test in https://github.com/prefix-dev/pixi/blob/main/tests/integration_python/test_run_cli.py ?
this reasonable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bollwyvl, new test looks good to me! Just one question
) -> list[Path]: | ||
"""Run a task, return the cache paths.""" | ||
verify_cli_command( | ||
[*map(str, [pixi.resolve(), "run", "--manifest-path", manifest_path, *args])], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it necessary to call .resolve()
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks again! |
thanks! |
references
changes
crates/pixi_task/src/task_hash.rs
TaskHash.task_args_hash