Making project Python 3.x compatible and fixing bugs #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2016 15:26
Also, making sure project follows PEP8 white-spaces directives with `autopep8` command
shackra
changed the title
|
Thank you for making this pull request. Could you revert the new lines? I know PEP8 says 80 chars is the maximum, but there is also a clause that says you can break little rules if it makes easier to read code. splitting those lines doesn't make the code easier to read... Also, the import's should be "from .views" for both python 2 and 3 (you don't need to catch the ImportError) |
|
omw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, making sure project follows PEP8 white-spaces directives with
autopep8command