Merge branch 'master' into feature/closure-lcd-interface

Author: sabollim-silabs

.gemini/styleguide.md

@@ -1,29 +1,37 @@
-# Gemini Code Review Instructions
+<!--
+IMPORTANT: This file should be kept in sync with the copilot instructions file. Any changes made here should be reflected there, and vice-versa, to maintain consistent review instructions for both AI tools.
+-->
+# Code Review Instructions
 
 - Do not comment on content for XML files or .matter content for clusters
-- The SDK is implementing an in-progress matter specification that may not be available yet.
-  Assume the matter specification is unknown and out of scope. Do not make uninformed assumptions
-  about the Matter specification, or its contents.
+- The SDK is implementing an in-progress matter specification that may not be
+  available yet. Assume the matter specification is unknown and out of scope. Do
+  not make uninformed assumptions about the Matter specification, or its
+  contents.
 - Do not comment unless a change is probably desirable
 - Do not repeat yourself. Be concise without losing meaning
-- Do not over-explain what you see in the code. Only describe code if there are specific questions or concerns (or if a question is asked)
-- Ensure that extensions or fixes to existing code should match the prevailing style of the original code
+- Do not over-explain what you see in the code. Only describe code if there are
+  specific questions or concerns (or if a question is asked)
+- Ensure that extensions or fixes to existing code should match the prevailing
+  style of the original code
 - Look for common typos and suggest fixes
 - Wrong years and years in the future are OK. Humans will catch these issues.
-- The SDK uses automated code formatting. Do not comment on whitespace, line length or other formatting
-  or whitespace issues. A code formatter will handle this.
+- The SDK uses automated code formatting. Do not comment on whitespace, line
+  length or other formatting or whitespace issues. A code formatter will handle
+  this.
 
 ## Development guides
 
-The SDK source code contains guides for development best practices in `docs/guides`, `docs/testing` and other `docs` locations.
-Use these as a reference for finding common patterns and potential issues in new code. In particular:
-  - [docs/guides/writing_clusters](https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/writing_clusters.md) describes how cluster handling
-    is to be implemented
-  - [docs/guides/migrating_ember_cluster_to_code_driven.md](https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/migrating_ember_cluster_to_code_driven.md)
-    describes how ember clusters can be migrated to code driven
-  - [docs/testing/unit_testing.md](https://github.com/project-chip/connectedhomeip/blob/master/docs/testing/unit_testing.md)
-    describes how to implement unit testing
-  - [docs/testing/integration_tests.md](https://github.com/project-chip/connectedhomeip/blob/master/docs/testing/integration_tests.md)
-    describes how to implement integration tests.
-
+The SDK source code contains guides for development best practices in
+`docs/guides`, `docs/testing` and other `docs` locations. Use these as a
+reference for finding common patterns and potential issues in new code. In
+particular:
 
+- [docs/guides/writing_clusters](https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/writing_clusters.md)
+  describes how cluster handling is to be implemented
+- [docs/guides/migrating_ember_cluster_to_code_driven.md](https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/migrating_ember_cluster_to_code_driven.md)
+  describes how ember clusters can be migrated to code driven
+- [docs/testing/unit_testing.md](https://github.com/project-chip/connectedhomeip/blob/master/docs/testing/unit_testing.md)
+  describes how to implement unit testing
+- [docs/testing/integration_tests.md](https://github.com/project-chip/connectedhomeip/blob/master/docs/testing/integration_tests.md)
+  describes how to implement integration tests.

.github/actions/delete-cache/action.yml

@@ -0,0 +1,41 @@
+name: 'Delete Cache'
+description: 'Deletes a GitHub Actions cache by key using the GitHub API'
+inputs:
+  cache-key:
+    required: true
+    description: 'The cache key to delete'
+  github-token:
+    required: true
+    description: 'GitHub token for API authentication'
+runs:
+  using: "composite"
+  steps:
+    - name: Delete cache
+      uses: actions/github-script@v7
+      env:
+        CACHE_KEY: ${{ inputs.cache-key }}
+      with:
+        github-token: ${{ inputs.github-token }}
+        script: |
+          const owner = context.repo.owner;
+          const repo = context.repo.repo;
+          const key = process.env.CACHE_KEY;
+          const ref = context.ref;
+          
+          core.info(`Attempting to delete cache: ${key}`);
+          
+          try {
+            await github.rest.actions.deleteActionsCacheByKey({
+              owner: owner,
+              repo: repo,
+              key: key,
+              ref: ref
+            });
+            core.info(`Successfully deleted cache`);
+          } catch (e) {
+            if (e.status === 404) {
+              core.info(`Cache not found (first run or already deleted)`);
+            } else {
+              core.warning(`Failed to delete cache: ${e.message}`);
+            }
+          }

.github/actions/setup-ccache/action.yml

@@ -23,16 +23,23 @@ runs:
   using: "composite"
   steps:
     - name: Configure ccache
-      shell: bash
-      run: |
-        mkdir -p .ccache
-        echo "CCACHE_BASEDIR=${{ github.workspace }}" >> $GITHUB_ENV
-        echo "CCACHE_SLOPPINESS=time_macros" >> $GITHUB_ENV
-        echo "CCACHE_DIR=${{ github.workspace }}/.ccache" >> $GITHUB_ENV
-        echo "CCACHE_COMPILERCHECK=content" >> $GITHUB_ENV
-        echo "CCACHE_MAXSIZE=5G" >> $GITHUB_ENV
-        echo "CCACHE_COMPRESS=1" >> $GITHUB_ENV
-        echo "CCACHE_COMPRESSLEVEL=6" >> $GITHUB_ENV
+      uses: pyTooling/Actions/[email protected]
+      with:
+        main: |
+          mkdir -p .ccache
+          echo "CCACHE_NOHASHDIR=1" >> $GITHUB_ENV
+          echo "CCACHE_BASEDIR=${{ github.workspace }}" >> $GITHUB_ENV
+          echo "CCACHE_NODIRECT=1" >> $GITHUB_ENV
+          echo "CCACHE_PREFIX_CPP=${{ github.workspace }}/scripts/helpers/ccache-prefix-cpp.sh" >> $GITHUB_ENV
+          echo "CCACHE_SLOPPINESS=time_macros" >> $GITHUB_ENV
+          echo "CCACHE_DIR=${{ github.workspace }}/.ccache" >> $GITHUB_ENV
+          echo "CCACHE_COMPILERCHECK=content" >> $GITHUB_ENV
+          echo "CCACHE_MAXSIZE=5G" >> $GITHUB_ENV
+          echo "CCACHE_COMPRESS=1" >> $GITHUB_ENV
+          echo "CCACHE_COMPRESSLEVEL=6" >> $GITHUB_ENV
+          echo "CHIP_PW_COMMAND_LAUNCHER=ccache" >> $GITHUB_ENV
+        post: |
+          ccache --show-stats
     - name: Optionally disable ccache
       if: ${{ inputs.disable == 'true' }}
       shell: bash
@@ -42,14 +49,11 @@ runs:
       id: cache-vars
       shell: bash
       run: |
-        CACHE_WEEK=$(date +%G-%V)
-        echo "CACHE_WEEK=${CACHE_WEEK}" >> "$GITHUB_ENV"
-
         CACHE_SUFFIX="${{ inputs.cache-suffix }}"
         if [ -n "$CACHE_SUFFIX" ]; then
-          CCACHE_KEY="ccache-${{ runner.os }}-${{ inputs.build-variant }}-w${CACHE_WEEK}-${CACHE_SUFFIX}"
+          CCACHE_KEY="ccache-${{ runner.os }}-${{ inputs.build-variant }}-${CACHE_SUFFIX}"
         else
-          CCACHE_KEY="ccache-${{ runner.os }}-${{ inputs.build-variant }}-w${CACHE_WEEK}"
+          CCACHE_KEY="ccache-${{ runner.os }}-${{ inputs.build-variant }}"
         fi
         echo "CCACHE_KEY=${CCACHE_KEY}" >> "$GITHUB_ENV"
         echo "cache_key=${CCACHE_KEY}" >> "$GITHUB_OUTPUT"

.github/copilot-instructions.md

@@ -0,0 +1,37 @@
+<!--
+IMPORTANT: This file should be kept in sync with the Gemini instructions file. Any changes made here should be reflected there, and vice-versa, to maintain consistent review instructions for both AI tools.
+-->
+# Code Review Instructions
+
+- Do not comment on content for XML files or .matter content for clusters
+- The SDK is implementing an in-progress matter specification that may not be
+  available yet. Assume the matter specification is unknown and out of scope. Do
+  not make uninformed assumptions about the Matter specification, or its
+  contents.
+- Do not comment unless a change is probably desirable
+- Do not repeat yourself. Be concise without losing meaning
+- Do not over-explain what you see in the code. Only describe code if there are
+  specific questions or concerns (or if a question is asked)
+- Ensure that extensions or fixes to existing code should match the prevailing
+  style of the original code
+- Look for common typos and suggest fixes
+- Wrong years and years in the future are OK. Humans will catch these issues.
+- The SDK uses automated code formatting. Do not comment on whitespace, line
+  length or other formatting or whitespace issues. A code formatter will handle
+  this.
+
+## Development guides
+
+The SDK source code contains guides for development best practices in
+`docs/guides`, `docs/testing` and other `docs` locations. Use these as a
+reference for finding common patterns and potential issues in new code. In
+particular:
+
+- [docs/guides/writing_clusters](https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/writing_clusters.md)
+  describes how cluster handling is to be implemented
+- [docs/guides/migrating_ember_cluster_to_code_driven.md](https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/migrating_ember_cluster_to_code_driven.md)
+  describes how ember clusters can be migrated to code driven
+- [docs/testing/unit_testing.md](https://github.com/project-chip/connectedhomeip/blob/master/docs/testing/unit_testing.md)
+  describes how to implement unit testing
+- [docs/testing/integration_tests.md](https://github.com/project-chip/connectedhomeip/blob/master/docs/testing/integration_tests.md)
+  describes how to implement integration tests.

.github/dependabot.yml

@@ -24,6 +24,7 @@ updates:
       - dependency-name: "third_party/mbedtls/repo"
       - dependency-name: "third_party/openthread/repo"
 
+      - dependency-name: "third_party/amazon-kinesis-video-streams-webrtc-sdk-c/repo"
       - dependency-name: "third_party/ameba/repo"
       - dependency-name: "third_party/android_deps/repo"
       - dependency-name: "third_party/asr/repo"
@@ -41,9 +42,6 @@ updates:
       - dependency-name: "third_party/libdatachannel/repo"
       - dependency-name: "third_party/libwebsockets/repo"
       - dependency-name: "third_party/lwip/repo"
-      - dependency-name: "third_party/mbed-mcu-boot/repo"
-      - dependency-name: "third_party/mbed-os-cypress-capsense-button/repo"
-      - dependency-name: "third_party/mbed-os-posix-socket/repo"
       - dependency-name: "third_party/mbedtls/repo"
       - dependency-name: "third_party/mt793x_sdk/repo"
       - dependency-name: "third_party/mynewt-core/repo"

.github/workflows/bloat_check.yaml

@@ -34,7 +34,7 @@ jobs:
         runs-on: ubuntu-latest
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
 
         steps:
             - name: Checkout

.github/workflows/build.yaml

@@ -43,7 +43,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]'
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
             volumes:
                 - "/:/runner-root-volume"
                 - "/tmp/log_output:/tmp/test_logs"
@@ -72,7 +72,7 @@ jobs:
                 platform: linux
             - name: Initialize CodeQL
               if: ${{ inputs.run-codeql  }}
-              uses: github/codeql-action/init@v3
+              uses: github/codeql-action/init@v4
               with:
                   languages: "cpp"
                   queries: security-extended, security-and-quality
@@ -120,7 +120,7 @@ jobs:
               if: inputs.run-codeql != true
               run: scripts/run_in_build_env.sh "ninja -C ./out"
             - name: Uploading core files
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v5
               if: ${{ failure() && !env.ACT }}
               with:
                   name: crash-core-linux-gcc-debug
@@ -138,7 +138,7 @@ jobs:
             # If re-enabling, some subset of this should be picked
             #
             # - name: Uploading objdir for debugging
-            #   uses: actions/upload-artifact@v4
+            #   uses: actions/upload-artifact@v5
             #   if: ${{ failure() && !env.ACT }}
             #   with:
             #       name: crash-objdir-linux-gcc-debug
@@ -153,7 +153,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]' && inputs.run-codeql != true
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
             volumes:
                 - "/:/runner-root-volume"
                 - "/tmp/log_output:/tmp/test_logs"
@@ -187,7 +187,7 @@ jobs:
             # deactivate until a better workaround is found
             # - name: Initialize CodeQL
             #   if: ${{ inputs.run-codeql  }}
-            #   uses: github/codeql-action/init@v3
+            #   uses: github/codeql-action/init@v4
             #   with:
             #       languages: "cpp"
             - name: Setup and Build Simulated Device
@@ -235,11 +235,6 @@ jobs:
             - name: Find changed files
               id: changed-files
               uses: tj-actions/changed-files@v47
-              with:
-                # Exclude all files under "third_party/"
-                files-ignore: |
-                  third_party/
-
             - name: Clang-tidy validation
               # NOTE: clang-tidy crashes on CodegenDataModel_Write due to Nullable/std::optional check.
               #       See https://github.com/llvm/llvm-project/issues/97426
@@ -303,7 +298,7 @@ jobs:
             #     language: cpp
 
             - name: Uploading core files
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v5
               if: ${{ failure() && !env.ACT }}
               with:
                   name: crash-core-linux
@@ -316,7 +311,7 @@ jobs:
             # If re-enabling, some subset of this should be picked
             #
             # - name: Uploading objdir for debugging
-            #   uses: actions/upload-artifact@v4
+            #   uses: actions/upload-artifact@v5
             #   if: ${{ failure() && !env.ACT }}
             #   with:
             #       name: crash-objdir-linux
@@ -331,7 +326,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]' && inputs.run-codeql != true
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
             volumes:
                 - "/:/runner-root-volume"
                 - "/tmp/log_output:/tmp/test_logs"
@@ -394,7 +389,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]' && inputs.run-codeql != true
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
             volumes:
                 - "/:/runner-root-volume"
                 - "/tmp/log_output:/tmp/test_logs"
@@ -423,7 +418,7 @@ jobs:
 
     build_darwin:
         name: Build on Darwin (clang, simulated)
-        runs-on: macos-13
+        runs-on: macos-14
         if: github.actor != 'restyled-io[bot]'  && inputs.run-codeql != true
 
         steps:
@@ -442,7 +437,7 @@ jobs:
             #  Build on Darwin + CodeQL often takes 6 hours (which is more than the maximum allowed by GitHub Runners), Deactivate it until we can investigate this
             # - name: Initialize CodeQL
             #   if: ${{ inputs.run-codeql  }}
-            #   uses: github/codeql-action/init@v3
+            #   uses: github/codeql-action/init@v4
             #   with:
             #       languages: "cpp"
 
@@ -492,7 +487,7 @@ jobs:
                        check \
                     "
             - name: Uploading diagnostic logs
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v5
               if: ${{ failure() && !env.ACT }}
               with:
                   name: crash-log-darwin
@@ -518,7 +513,7 @@ jobs:
         runs-on: ubuntu-latest
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
             options: --privileged --sysctl "net.ipv6.conf.all.disable_ipv6=0
                 net.ipv4.conf.all.forwarding=0 net.ipv6.conf.all.forwarding=0"
 

.github/workflows/cert_test_checks.yaml

@@ -16,8 +16,6 @@ name: Certification test checks
 
 on:
   pull_request:
-    paths:
-      - "src/app/tests/suites/certification/**"
 permissions:
   contents: read
 
@@ -33,7 +31,8 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v5
         with:
-          fetch-depth: 0
+          # Clone more than one commit because we need HEAD^..HEAD diff
+          fetch-depth: 2
       - name: Run checks
         run: |
           python3 scripts/tests/matter_yaml_linter.py