Support TCP over IPv4 #40979
Merged
Support TCP over IPv4 #40979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #40979: Size comparison from d03ab78 to 0fda556 Increases above 0.2%:
Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40979 +/- ##
=======================================
Coverage 50.95% 50.95%
=======================================
Files 1378 1378
Lines 100642 100645 +3
Branches 13026 13026
=======================================
+ Hits 51282 51285 +3
Misses 49360 49360 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #40979: Size comparison from 3640a4f to e439adf Increases above 0.2%:
Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
samadDotDev
requested review from
chulspro,
marktrayer,
pidarped,
robszewczyk and
yufengwangca
|
@suyambulingamrm brought this up with recently seen instances of this issue, and validated that the PR addresses those:
We also had an ecosystem/controller test run on this to make sure that we're able to connect via TCP over IPv4 to the devices that may just be using that address type (which we do see a lot in the field due to old network equipment or variousnetwork configurations) |
|
PR #40979: Size comparison from e2f86ee to 4a21a32 Increases above 0.2%:
Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
pidarped
approved these changes
Oct 9, 2025
marktrayer
approved these changes
Oct 9, 2025
chulspro
approved these changes
Oct 10, 2025
|
PR #40979: Size comparison from 2fc5ce8 to 5749d86 Increases above 0.2%:
Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #40979: Size comparison from 876fcf5 to d66c541 Increases above 0.2%:
Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds another transport tuple entry for TCP over ipv4, mirroring UDP over ipv4 support. We do observe a lot of network setups in the field where ipv4 ends up being the only reachable address for Matter nodes, and this is therefore allowing TCP to connect over that address.
Related issues
Fixes #37023
Fixes project-chip/certification-tool#676
Testing
Manually tested between controller and all-clusters-app with the resolution of just ipv4 address in the network environment.
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines