Set Identify ClusterRevision as external and implement read handler #41287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and use the generated MetaData Revision constant
github-actions
bot
added
examples
scripts
controller
app
examples chef
There was a problem hiding this comment.
Pull Request Overview
This PR implements external cluster revision handling for the Identify cluster to align with specification changes. The revision is updated from 5 to 6 and the implementation moves from RAM storage to external read handlers.
- Makes the Identify cluster's ClusterRevision attribute external and implements read handler using generated constants
- Updates the cluster XML to sync with spec revision 6 using alchemy
- Regenerates all .zap and .matter files to reflect the external attribute configuration
Reviewed Changes
Copilot reviewed 126 out of 126 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/zap-templates/zcl/zcl.json | Adds Identify cluster to external attributes list |
| src/app/zap-templates/zcl/zcl-with-test-extensions.json | Adds Identify cluster to external attributes list |
| src/app/zap-templates/zcl/data-model/chip/identify-cluster.xml | Updates cluster revision from 5 to 6 and other spec alignment changes |
| src/app/clusters/identify-server/identify-server.h | Adds IdentifyAttrAccess class declaration for external attribute handling |
| src/app/clusters/identify-server/identify-server.cpp | Implements read handler for ClusterRevision attribute using Identify::kRevision constant |
| zzz_generated/app-common/clusters/Identify/Metadata.h | Updates revision constant from 5 to 6 |
| zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.h | Removes ClusterRevision accessor declarations |
| zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp | Removes ClusterRevision accessor implementations |
| scripts/tools/zap/tests/outputs/.../endpoint_config.h | Updates attribute configuration to external storage |
| examples/.../...matter | Updates cluster revision from 5 to 6 and changes from ram to callback attributes |
Comments suppressed due to low confidence (1)
lpbeliveau-silabs
approved these changes
Oct 6, 2025
|
PR #41287: Size comparison from b0f2fa3 to 75f1bb3 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
This is probably completely superseeded by #41232 . However it also is probably low risk and shows that doing the right thing adds a flash overhead by itself. I guess merge will not be too bad and then we see overhead of code driven compared to AAI on the other PR ... so we can merge this one. |
andy31415
approved these changes
Oct 6, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41287 +/- ##
==========================================
+ Coverage 50.96% 50.97% +0.01%
==========================================
Files 1378 1378
Lines 100597 100610 +13
Branches 13023 13018 -5
==========================================
+ Hits 51267 51284 +17
+ Misses 49330 49326 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bzbarsky-apple
requested changes
Oct 6, 2025
jmartinez-silabs
force-pushed
the
identity_cluster_revision
branch
from
74ceb39 to
6ec64bd
Compare
|
PR #41287: Size comparison from 42525d0 to 6ec64bd Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #41287: Size comparison from cfa7f13 to 7ad735e Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
bzbarsky-apple
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Cluster Revision should not be set by a Zap config. It shall follow the spec changes and xml updates we do, based on the spec/alchemy results.
This PR is one of a series I'll complete over the next couple of days.
What is done :
Set the Cluster Revision attribute of the Identify cluster to always be external by listing the attribute in
Implement the Read handler for the Cluster Revision Attribute in
src/app/clusters/identify-server/identify-server.cppUse the generated constant
Identify::kRevision, fromclusters/Identify/Metadata.h, as the ClusterRevision value to be encoded.The Identify.xml was out of sync with the spec by 1 revision. Changes are small so I integrated it in this pr.
Commit 2 Updates src/app/zap-templates/zcl/data-model/chip/identify-cluster.xml using alchemy
alchemy zap --sdkRoot=./connectedhomeip --specRoot=./connectedhomeip-spec './connectedhomeip-spec/src/app_clusters/Identify.adoc'Finally, in a separate commit. I ran ./scripts/tools/zap_regen_all.py to update all .zap and .matter files as the attribute changes from RAM to External
Related issues
n/a
Testing
Build and commission the SIlabs Lighting-app. Use chip-tool to read the ClusterRevision of the Identify cluster.
Readability checklist
commit 1 is my manual changes
commit 2 is alchemy generation changes
commit 3 is zap regen changes