[PushAV] Update to latest spec for Push Events and TransportOptions #41327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
darwin
controller
app
tests
examples chef
|
PR #41327: Size comparison from c432a84 to 544eef3 Full report (5 builds for cc32xx, realtek, stm32)
|
|
PR #41327: Size comparison from c432a84 to 660a8cb Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
|
PR #41327: Size comparison from c432a84 to 2c15ad2 Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
|
PR #41327: Size comparison from c432a84 to 8ecaf51 Full report (5 builds for cc32xx, realtek, stm32)
|
|
PR #41327: Size comparison from c432a84 to 4db9746 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41327 +/- ##
=======================================
Coverage 50.96% 50.96%
=======================================
Files 1378 1378
Lines 100614 100612 -2
Branches 13025 13025
=======================================
- Hits 51273 51272 -1
+ Misses 49341 49340 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #41327: Size comparison from c432a84 to 74e478d Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
pidarped
approved these changes
Oct 8, 2025
|
PR #41327: Size comparison from 82e6d0e to 035d9b5 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
saurabhst
approved these changes
Oct 9, 2025
aronrosenberg
approved these changes
Oct 10, 2025
|
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing showed that the PushTransportEnd Event in the SDK was mis-aligned with the Spec (had two fields that had been removed). Also the TransportOptions endpointID has been renamed TLSEndpointID.
Ran Alchemy against the latest cluster definition.
Ran ZapRegen.
Updated the server, app, and test scripts with new naming and event definition.
Related issues
Testing
Via the Python Runner re-run PAVST.* and PAVSTI.*
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines