report API Maturity (e.g. provisional) status on events in IDL files #41365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
controller
app
examples chef
|
PR #41365: Size comparison from f8b6907 to 8641ece Full report (12 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, realtek, stm32)
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for marking events as "provisional" in IDL (.matter) files by implementing a ZAP template change that checks for the apiMaturity field and outputs it as a qualifier before event declarations.
Key Changes
- Modified ZAP template to include
apiMaturityqualifier before event definitions - Applied provisional qualifier to all relevant events across multiple .matter files through automated regeneration
- Added proper spacing handling for the new qualifier in template output
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/zap-templates/partials/idl/cluster_definition.zapt | Template modification to output apiMaturity qualifier for events |
| src/controller/data_model/controller-clusters.matter | Auto-generated changes adding provisional qualifier to events |
| examples/thermostat/thermostat-common/thermostat.matter | Auto-generated changes adding provisional qualifier to thermostat events |
| examples/thermostat/qpg/zap/thermostaticRadiatorValve.matter | Auto-generated changes adding provisional qualifier to thermostat events |
| examples/thermostat/nxp/zap/*.matter | Auto-generated changes adding provisional qualifier to thermostat events |
| examples/chef/devices/*.matter | Auto-generated changes adding provisional qualifier to events in chef device configs |
| examples/placeholder/linux/apps/*.matter | Auto-generated changes adding provisional qualifier to events |
| examples/energy-management-app/*.matter | Auto-generated changes adding provisional qualifier to energy management events |
| examples/dishwasher-app/silabs/*.matter | Auto-generated changes adding provisional qualifier to energy management events |
| examples/all-clusters-/.matter | Auto-generated changes adding provisional qualifier to events |
| examples/air-purifier-app/*.matter | Auto-generated changes adding provisional qualifier to thermostat events |
Alami-Amine
force-pushed
the
AA/ProvisionalEvent
branch
2 times, most recently
from
7870b02 to
2bac5b5
Compare
|
PR #41365: Size comparison from 82e6d0e to 5f41e67 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
tcarmelveilleux
approved these changes
Oct 9, 2025
|
PR #41365: Size comparison from 82e6d0e to dd6e0a2 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Alami-Amine
changed the title
shubhamdp
approved these changes
Oct 10, 2025
jmartinez-silabs
approved these changes
Oct 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41365 +/- ##
=======================================
Coverage 50.95% 50.95%
=======================================
Files 1378 1378
Lines 100663 100663
Branches 13029 13029
=======================================
Hits 51292 51292
Misses 49371 49371 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Alami-Amine
force-pushed
the
AA/ProvisionalEvent
branch
from
dd6e0a2 to
1c61781
Compare
|
PR #41365: Size comparison from a83d0cb to 1c61781 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.matterIDL files.apiMaturityin ZAP --> adding support forapiMaturityhandling to Events zap#1637Testing
scripts/tools/zap_regen_all.pyto make sure provisional is added to IDL files.