[PAVST] Align privacy checks with spec #41378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #41378: Size comparison from e2f86ee to 490bb25 Full report (5 builds for cc32xx, realtek, stm32)
|
|
PR #41378: Size comparison from e2f86ee to 5263b84 Full report (3 builds for cc32xx, stm32)
|
|
PR #41378: Size comparison from e2f86ee to 3c76260 Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41378 +/- ##
=======================================
Coverage 50.95% 50.95%
=======================================
Files 1378 1378
Lines 100642 100660 +18
Branches 13026 13028 +2
=======================================
+ Hits 51282 51292 +10
- Misses 49360 49368 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #41378: Size comparison from e2f86ee to 73f23e9 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #41378: Size comparison from e2f86ee to 9480cef Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
chulspro
approved these changes
Oct 10, 2025
|
PR #41378: Size comparison from 876fcf5 to db1e8ea Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
yufengwangca
approved these changes
Oct 10, 2025
vnkavali
approved these changes
Oct 10, 2025
pidarped
approved these changes
Oct 10, 2025
|
Darwin is backlogged and we are nearing build cutoff. Merging without waiting for darwin framework tests as this PR is unlikely to affect the darwin framework anyway. REPL tests would have caught issues if those apply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PushAV doesn't apply privacy to an allocate
On a manual trigger privacy applied is stream usage dependent, add that logic.
On a transport change to Active, any privacy present will prevent
Fixes #41397
Related issues
Testing
PAVST 2.3, 2.6, and 2.7 via the Python Runner
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines